Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(205)

Issue 2604923002: Use TaskScheduler instead of WorkerPool in extension_printer_handler.cc. (Closed)

Created:
3 years, 12 months ago by fdoray
Modified:
3 years, 11 months ago
Reviewers:
Scott Byer
CC:
chromium-apps-reviews_chromium.org, chromium-reviews, extensions-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use TaskScheduler instead of WorkerPool in extension_printer_handler.cc. The following traits are used: Priority: Inherited (default) The priority is inherited from the calling context (i.e. TaskTraits are initialized with the priority of the current task). Shutdown behavior: CONTINUE_ON_SHUTDOWN Tasks posted with this mode which have not started executing before shutdown is initiated will never run. Tasks with this mode running at shutdown will be ignored (the worker will not be joined). Note: Tasks that were previously posted to base::WorkerPool should use this shutdown behavior because this is how base::WorkerPool handles all its tasks. May Block: Tasks posted with MayBlock() may block. This includes but is not limited to tasks that wait on synchronous file I/O operations: read or write a file from disk, interact with a pipe or a socket, rename or delete a file, enumerate files in a directory, etc. This trait isn't required for the mere use of locks. BUG=659191 Review-Url: https://codereview.chromium.org/2604923002 Cr-Commit-Position: refs/heads/master@{#442953} Committed: https://chromium.googlesource.com/chromium/src/+/081e3d8b2d5a1ce6e9485f7c417ca44dca65f5e2

Patch Set 1 #

Patch Set 2 : explicit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -25 lines) Patch
M chrome/browser/ui/webui/print_preview/extension_printer_handler.h View 1 3 chunks +1 line, -6 lines 0 comments Download
M chrome/browser/ui/webui/print_preview/extension_printer_handler.cc View 5 chunks +10 lines, -13 lines 0 comments Download
M chrome/browser/ui/webui/print_preview/extension_printer_handler_unittest.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M chrome/browser/ui/webui/print_preview/printer_handler.cc View 1 chunk +2 lines, -3 lines 0 comments Download

Messages

Total messages: 17 (12 generated)
fdoray
PTAL
3 years, 11 months ago (2016-12-31 19:38:29 UTC) #9
fdoray
On 2016/12/31 19:38:29, fdoray wrote: > PTAL ping
3 years, 11 months ago (2017-01-10 19:44:05 UTC) #11
Scott Byer
lgtm
3 years, 11 months ago (2017-01-11 17:14:35 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2604923002/20001
3 years, 11 months ago (2017-01-11 17:15:09 UTC) #14
commit-bot: I haz the power
3 years, 11 months ago (2017-01-11 18:03:30 UTC) #17
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/081e3d8b2d5a1ce6e9485f7c417c...

Powered by Google App Engine
This is Rietveld 408576698