third_party/WebKit/Source/devtools/front_end/ui/ListWidget.js - Issue 2604883002: DevTools: namespace globals

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/ui/ListWidget.js

Issue 2604883002: DevTools: namespace globals (Closed)

Patch Set: address CL feedback Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/devtools/front_end/ui/ListWidget.js

diff --git a/third_party/WebKit/Source/devtools/front_end/ui/ListWidget.js b/third_party/WebKit/Source/devtools/front_end/ui/ListWidget.js

index 7878a136b0c99dc7b1ca49b7aff8e405765269c7..0832723a1696e0faadb7e1c81456b6909001c854 100644

--- a/third_party/WebKit/Source/devtools/front_end/ui/ListWidget.js

+++ b/third_party/WebKit/Source/devtools/front_end/ui/ListWidget.js

@@ -260,9 +260,9 @@ UI.ListWidget.Editor = class {

this._contentElement = this.element.createChild('div', 'editor-content');

var buttonsRow = this.element.createChild('div', 'editor-buttons');

- this._commitButton = createTextButton('', this._commitClicked.bind(this));

+ this._commitButton = UI.createTextButton('', this._commitClicked.bind(this));

buttonsRow.appendChild(this._commitButton);

- this._cancelButton = createTextButton(Common.UIString('Cancel'), this._cancelClicked.bind(this));

+ this._cancelButton = UI.createTextButton(Common.UIString('Cancel'), this._cancelClicked.bind(this));

this._cancelButton.addEventListener(

'keydown', onKeyDown.bind(null, isEnterKey, this._cancelClicked.bind(this)), false);

buttonsRow.appendChild(this._cancelButton);