third_party/WebKit/Source/devtools/front_end/ui/Icon.js - Issue 2604883002: DevTools: namespace globals

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/ui/Icon.js

Issue 2604883002: DevTools: namespace globals (Closed)

Patch Set: address CL feedback Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/devtools/front_end/ui/Icon.js

diff --git a/third_party/WebKit/Source/devtools/front_end/ui/Icon.js b/third_party/WebKit/Source/devtools/front_end/ui/Icon.js

index 909796867e1b37b4fecc8d700e7ded819f8e99f8..6bcc79aff69243832c9dc4ee52540f82bb1c389a 100644

--- a/third_party/WebKit/Source/devtools/front_end/ui/Icon.js

+++ b/third_party/WebKit/Source/devtools/front_end/ui/Icon.js

@@ -19,7 +19,7 @@ UI.Icon = class extends HTMLSpanElement {

static create(iconType, className) {

if (!UI.Icon._constructor)

- UI.Icon._constructor = registerCustomElement('span', 'ui-icon', UI.Icon.prototype);

+ UI.Icon._constructor = UI.registerCustomElement('span', 'ui-icon', UI.Icon.prototype);

var icon = /** @type {!UI.Icon} */ (new UI.Icon._constructor());

if (className)