third_party/WebKit/Source/devtools/front_end/timeline/TimelineLandingPage.js - Issue 2604883002: DevTools: namespace globals

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/timeline/TimelineLandingPage.js

Issue 2604883002: DevTools: namespace globals (Closed)

Patch Set: address CL feedback Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/sources/XHRBreakpointsSidebarPane.js ('k') | third_party/WebKit/Source/devtools/front_end/timeline/TimelinePanel.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/timeline/TimelineLandingPage.js

diff --git a/third_party/WebKit/Source/devtools/front_end/timeline/TimelineLandingPage.js b/third_party/WebKit/Source/devtools/front_end/timeline/TimelineLandingPage.js

index 7bb3c028f4d5a988737ddb3d83b80fd98caad97b..af1063769116e34fed7141f233d78bd1a294fbc0 100644

--- a/third_party/WebKit/Source/devtools/front_end/timeline/TimelineLandingPage.js

+++ b/third_party/WebKit/Source/devtools/front_end/timeline/TimelineLandingPage.js

@@ -11,8 +11,8 @@ Timeline.TimelineLandingPage = class extends UI.VBox {

this._tabbedPane = new UI.TabbedPane();

this._tabbedPane.setTabSlider(true);

this._tabbedPane.renderWithNoHeaderBackground();

- this._currentTabSetting = Common.settings.createSetting(

- 'performanceLandingPageTab', Timeline.TimelineLandingPage.PageId.Basic);

+ this._currentTabSetting =

+ Common.settings.createSetting('performanceLandingPageTab', Timeline.TimelineLandingPage.PageId.Basic);

var tab = new Timeline.TimelineLandingPage.PerspectiveTabWidget();

tab.appendDescription(Common.UIString(

@@ -120,8 +120,8 @@ Timeline.TimelineLandingPage.PerspectiveTabWidget = class extends UI.VBox {

this._forceEnable = new Map();

this._descriptionDiv = this.contentElement.createChild('div', 'timeline-perspective-description');

this._actionButtonDiv = this.contentElement.createChild('div');

- this._actionButtonDiv.appendChild(createTextButton(Common.UIString('Start profiling'), this._record));

- this._actionButtonDiv.appendChild(createTextButton(Common.UIString('Profile page load'), this._recordPageLoad));

+ this._actionButtonDiv.appendChild(UI.createTextButton(Common.UIString('Start profiling'), this._record));

+ this._actionButtonDiv.appendChild(UI.createTextButton(Common.UIString('Profile page load'), this._recordPageLoad));

}

/**