third_party/WebKit/Source/devtools/front_end/sources/XHRBreakpointsSidebarPane.js - Issue 2604883002: DevTools: namespace globals

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/sources/XHRBreakpointsSidebarPane.js

Issue 2604883002: DevTools: namespace globals (Closed)

Patch Set: address CL feedback Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/sources/RevisionHistoryView.js ('k') | third_party/WebKit/Source/devtools/front_end/timeline/TimelineLandingPage.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/sources/XHRBreakpointsSidebarPane.js

diff --git a/third_party/WebKit/Source/devtools/front_end/sources/XHRBreakpointsSidebarPane.js b/third_party/WebKit/Source/devtools/front_end/sources/XHRBreakpointsSidebarPane.js

index d21e64411a579118adf8c898517d6dcf3d3b6518..64526f5893249cf12124f47123b33a4cdc661867 100644

--- a/third_party/WebKit/Source/devtools/front_end/sources/XHRBreakpointsSidebarPane.js

+++ b/third_party/WebKit/Source/devtools/front_end/sources/XHRBreakpointsSidebarPane.js

@@ -99,7 +99,7 @@ Sources.XHRBreakpointsSidebarPane = class extends Components.BreakpointsSidebarP

element.addEventListener('contextmenu', this._contextMenu.bind(this, url), true);

var title = url ? Common.UIString('URL contains "%s"', url) : Common.UIString('Any XHR');

- var label = createCheckboxLabel(title, enabled);

+ var label = UI.createCheckboxLabel(title, enabled);

element.appendChild(label);

label.checkboxElement.addEventListener('click', this._checkboxClicked.bind(this, url), false);

element._checkboxElement = label.checkboxElement;