Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(484)

Unified Diff: third_party/WebKit/Source/devtools/front_end/sources/NavigatorView.js

Issue 2604883002: DevTools: namespace globals (Closed)
Patch Set: address CL feedback Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/sources/NavigatorView.js
diff --git a/third_party/WebKit/Source/devtools/front_end/sources/NavigatorView.js b/third_party/WebKit/Source/devtools/front_end/sources/NavigatorView.js
index da9800b03a96ce0c2353503b7ac6fca2226278fd..e9f0577bb54612366999201fb5b1f9f30cfb855c 100644
--- a/third_party/WebKit/Source/devtools/front_end/sources/NavigatorView.js
+++ b/third_party/WebKit/Source/devtools/front_end/sources/NavigatorView.js
@@ -34,7 +34,7 @@ Sources.NavigatorView = class extends UI.VBox {
super();
this.registerRequiredCSS('sources/navigatorView.css');
- this._scriptsTree = new TreeOutlineInShadow();
+ this._scriptsTree = new UI.TreeOutlineInShadow();
this._scriptsTree.registerRequiredCSS('sources/navigatorTree.css');
this._scriptsTree.setComparator(Sources.NavigatorView._treeElementsCompare);
this.element.appendChild(this._scriptsTree.element);
@@ -81,7 +81,7 @@ Sources.NavigatorView = class extends UI.VBox {
}
/**
- * @param {!TreeElement} treeElement
+ * @param {!UI.TreeElement} treeElement
*/
static _treeElementOrder(treeElement) {
if (treeElement._boostOrder)
@@ -148,8 +148,8 @@ Sources.NavigatorView = class extends UI.VBox {
}
/**
- * @param {!TreeElement} treeElement1
- * @param {!TreeElement} treeElement2
+ * @param {!UI.TreeElement} treeElement1
+ * @param {!UI.TreeElement} treeElement2
* @return {number}
*/
static _treeElementsCompare(treeElement1, treeElement2) {
@@ -835,7 +835,7 @@ Sources.NavigatorView.Types = {
/**
* @unrestricted
*/
-Sources.NavigatorFolderTreeElement = class extends TreeElement {
+Sources.NavigatorFolderTreeElement = class extends UI.TreeElement {
/**
* @param {!Sources.NavigatorView} navigatorView
* @param {string} type
@@ -926,7 +926,7 @@ Sources.NavigatorFolderTreeElement = class extends TreeElement {
/**
* @unrestricted
*/
-Sources.NavigatorSourceTreeElement = class extends TreeElement {
+Sources.NavigatorSourceTreeElement = class extends UI.TreeElement {
/**
* @param {!Sources.NavigatorView} navigatorView
* @param {!Workspace.UISourceCode} uiSourceCode
@@ -1085,7 +1085,7 @@ Sources.NavigatorTreeNode = class {
}
/**
- * @return {!TreeElement}
+ * @return {!UI.TreeElement}
*/
treeNode() {
throw 'Not implemented';
@@ -1130,7 +1130,7 @@ Sources.NavigatorTreeNode = class {
wasPopulated() {
var children = this.children();
for (var i = 0; i < children.length; ++i)
- this.treeNode().appendChild(/** @type {!TreeElement} */ (children[i].treeNode()));
+ this.treeNode().appendChild(/** @type {!UI.TreeElement} */ (children[i].treeNode()));
}
/**
@@ -1138,7 +1138,7 @@ Sources.NavigatorTreeNode = class {
*/
didAddChild(node) {
if (this.isPopulated())
- this.treeNode().appendChild(/** @type {!TreeElement} */ (node.treeNode()));
+ this.treeNode().appendChild(/** @type {!UI.TreeElement} */ (node.treeNode()));
}
/**
@@ -1146,7 +1146,7 @@ Sources.NavigatorTreeNode = class {
*/
willRemoveChild(node) {
if (this.isPopulated())
- this.treeNode().removeChild(/** @type {!TreeElement} */ (node.treeNode()));
+ this.treeNode().removeChild(/** @type {!UI.TreeElement} */ (node.treeNode()));
}
/**
@@ -1224,7 +1224,7 @@ Sources.NavigatorRootTreeNode = class extends Sources.NavigatorTreeNode {
/**
* @override
- * @return {!TreeElement}
+ * @return {!UI.TreeElement}
*/
treeNode() {
return this._navigatorView._scriptsTree.rootElement();
@@ -1256,7 +1256,7 @@ Sources.NavigatorUISourceCodeTreeNode = class extends Sources.NavigatorTreeNode
/**
* @override
- * @return {!TreeElement}
+ * @return {!UI.TreeElement}
*/
treeNode() {
if (this._treeElement)
@@ -1401,7 +1401,7 @@ Sources.NavigatorFolderTreeNode = class extends Sources.NavigatorTreeNode {
/**
* @override
- * @return {!TreeElement}
+ * @return {!UI.TreeElement}
*/
treeNode() {
if (this._treeElement)
@@ -1423,7 +1423,7 @@ Sources.NavigatorFolderTreeNode = class extends Sources.NavigatorTreeNode {
}
/**
- * @return {!TreeElement}
+ * @return {!UI.TreeElement}
*/
_createTreeElement(title, node) {
if (this._project.type() !== Workspace.projectTypes.FileSystem) {
@@ -1570,7 +1570,7 @@ Sources.NavigatorGroupTreeNode = class extends Sources.NavigatorTreeNode {
/**
* @override
- * @return {!TreeElement}
+ * @return {!UI.TreeElement}
*/
treeNode() {
if (this._treeElement)

Powered by Google App Engine
This is Rietveld 408576698