third_party/WebKit/Source/devtools/front_end/sources/JavaScriptBreakpointsSidebarPane.js - Issue 2604883002: DevTools: namespace globals

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/sources/JavaScriptBreakpointsSidebarPane.js

Issue 2604883002: DevTools: namespace globals (Closed)

Patch Set: address CL feedback Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/sources/FileBasedSearchResultsPane.js ('k') | third_party/WebKit/Source/devtools/front_end/sources/NavigatorView.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/sources/JavaScriptBreakpointsSidebarPane.js

diff --git a/third_party/WebKit/Source/devtools/front_end/sources/JavaScriptBreakpointsSidebarPane.js b/third_party/WebKit/Source/devtools/front_end/sources/JavaScriptBreakpointsSidebarPane.js

index 3ac3e1fa7e91ddac9298c77a49614e736a58ed4e..1ec97df65295e6ebbb3fcd17fe80864626cb90d1 100644

--- a/third_party/WebKit/Source/devtools/front_end/sources/JavaScriptBreakpointsSidebarPane.js

+++ b/third_party/WebKit/Source/devtools/front_end/sources/JavaScriptBreakpointsSidebarPane.js

@@ -66,7 +66,7 @@ Sources.JavaScriptBreakpointsSidebarPane = class extends UI.ThrottledWidget {

entry = this._listElement.createChild('div', 'breakpoint-entry');

entry.addEventListener('contextmenu', this._breakpointContextMenu.bind(this), true);

entry.addEventListener('click', this._revealLocation.bind(this), false);

- var checkboxLabel = createCheckboxLabel('');

+ var checkboxLabel = UI.createCheckboxLabel('');

checkboxLabel.addEventListener('click', this._breakpointCheckboxClicked.bind(this), false);

entry.appendChild(checkboxLabel);

entry[Sources.JavaScriptBreakpointsSidebarPane._checkboxLabelSymbol] = checkboxLabel;