Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(903)

Unified Diff: third_party/WebKit/Source/devtools/front_end/settings/SettingsScreen.js

Issue 2604883002: DevTools: namespace globals (Closed)
Patch Set: address CL feedback Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/settings/SettingsScreen.js
diff --git a/third_party/WebKit/Source/devtools/front_end/settings/SettingsScreen.js b/third_party/WebKit/Source/devtools/front_end/settings/SettingsScreen.js
index 37d4a3b718c42c86a491a335b0a6e5bb76f9a3b3..ca1dcafedc7244c74bdcf12ec3b8d6810d6c4d1d 100644
--- a/third_party/WebKit/Source/devtools/front_end/settings/SettingsScreen.js
+++ b/third_party/WebKit/Source/devtools/front_end/settings/SettingsScreen.js
@@ -177,7 +177,7 @@ Settings.GenericSettingsTab = class extends Settings.SettingsTab {
self.runtime.extensions(UI.SettingUI).forEach(this._addSettingUI.bind(this));
this._appendSection().appendChild(
- createTextButton(Common.UIString('Restore defaults and reload'), restoreAndReload));
+ UI.createTextButton(Common.UIString('Restore defaults and reload'), restoreAndReload));
function restoreAndReload() {
Common.settings.clearAll();
@@ -290,7 +290,7 @@ Settings.WorkspaceSettingsTab = class extends Settings.SettingsTab {
this._fileSystemsListContainer = this.containerElement.createChild('div', '');
this.containerElement.appendChild(
- createTextButton(Common.UIString('Add folder\u2026'), this._addFileSystemClicked.bind(this)));
+ UI.createTextButton(Common.UIString('Add folder\u2026'), this._addFileSystemClicked.bind(this)));
/** @type {!Map<string, !Element>} */
this._elementByPath = new Map();
@@ -438,7 +438,7 @@ Settings.ExperimentsSettingsTab = class extends Settings.SettingsTab {
}
_createExperimentCheckbox(experiment) {
- var label = createCheckboxLabel(Common.UIString(experiment.title), experiment.isEnabled());
+ var label = UI.createCheckboxLabel(Common.UIString(experiment.title), experiment.isEnabled());
var input = label.checkboxElement;
input.name = experiment.name;
function listener() {

Powered by Google App Engine
This is Rietveld 408576698