third_party/WebKit/Source/devtools/front_end/sources/AdvancedSearchView.js - Issue 2604883002: DevTools: namespace globals

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/sources/AdvancedSearchView.js

Issue 2604883002: DevTools: namespace globals (Closed)

Patch Set: address CL feedback Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/settings/SettingsScreen.js ('k') | third_party/WebKit/Source/devtools/front_end/sources/EventListenerBreakpointsSidebarPane.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/sources/AdvancedSearchView.js

diff --git a/third_party/WebKit/Source/devtools/front_end/sources/AdvancedSearchView.js b/third_party/WebKit/Source/devtools/front_end/sources/AdvancedSearchView.js

index 38adfd2c04bd8d9623273f348708e6f972c73e45..1bc8b2fcdcd6b99bc1d9c334a8337e56775e98a5 100644

--- a/third_party/WebKit/Source/devtools/front_end/sources/AdvancedSearchView.js

+++ b/third_party/WebKit/Source/devtools/front_end/sources/AdvancedSearchView.js

@@ -34,13 +34,13 @@ Sources.AdvancedSearchView = class extends UI.VBox {

this._searchInputClearElement.hidden = true;

this._searchInputClearElement.addEventListener('click', this._onSearchInputClear.bind(this), false);

- this._ignoreCaseLabel = createCheckboxLabel(Common.UIString('Ignore case'));

+ this._ignoreCaseLabel = UI.createCheckboxLabel(Common.UIString('Ignore case'));

this._ignoreCaseLabel.classList.add('search-config-label');

this._searchPanelElement.appendChild(this._ignoreCaseLabel);

this._ignoreCaseCheckbox = this._ignoreCaseLabel.checkboxElement;

this._ignoreCaseCheckbox.classList.add('search-config-checkbox');

- this._regexLabel = createCheckboxLabel(Common.UIString('Regular expression'));

+ this._regexLabel = UI.createCheckboxLabel(Common.UIString('Regular expression'));

this._regexLabel.classList.add('search-config-label');

this._searchPanelElement.appendChild(this._regexLabel);

this._regexCheckbox = this._regexLabel.checkboxElement;