Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1434)

Unified Diff: third_party/WebKit/Source/devtools/front_end/security/SecurityPanel.js

Issue 2604883002: DevTools: namespace globals (Closed)
Patch Set: address CL feedback Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/security/SecurityPanel.js
diff --git a/third_party/WebKit/Source/devtools/front_end/security/SecurityPanel.js b/third_party/WebKit/Source/devtools/front_end/security/SecurityPanel.js
index ae1b3ed2cdf21b50a7c8f0e42baff930a7d4f1d1..a7e7edfee63dab1465057431b699525319819597 100644
--- a/third_party/WebKit/Source/devtools/front_end/security/SecurityPanel.js
+++ b/third_party/WebKit/Source/devtools/front_end/security/SecurityPanel.js
@@ -52,7 +52,7 @@ Security.SecurityPanel = class extends UI.PanelWithSidebar {
panel.showCertificateViewer();
}
- return createTextButton(text, showCertificateViewer, 'security-certificate-button');
+ return UI.createTextButton(text, showCertificateViewer, 'security-certificate-button');
}
/**
@@ -73,7 +73,7 @@ Security.SecurityPanel = class extends UI.PanelWithSidebar {
SDK.multitargetNetworkManager.getCertificate(origin, certificateCallback);
}
- return createTextButton(text, showCertificateViewer, 'security-certificate-button');
+ return UI.createTextButton(text, showCertificateViewer, 'security-certificate-button');
}
/**
@@ -383,7 +383,7 @@ Security.SecurityPanel.OriginState;
/**
* @unrestricted
*/
-Security.SecurityPanelSidebarTree = class extends TreeOutlineInShadow {
+Security.SecurityPanelSidebarTree = class extends UI.TreeOutlineInShadow {
/**
* @param {!Security.SecurityPanelSidebarTreeElement} mainViewElement
* @param {function(!Security.SecurityPanel.Origin)} showOriginInPanel
@@ -397,12 +397,12 @@ Security.SecurityPanelSidebarTree = class extends TreeOutlineInShadow {
this._showOriginInPanel = showOriginInPanel;
this._mainOrigin = null;
- /** @type {!Map<!Security.SecurityPanelSidebarTree.OriginGroupName, !TreeElement>} */
+ /** @type {!Map<!Security.SecurityPanelSidebarTree.OriginGroupName, !UI.TreeElement>} */
this._originGroups = new Map();
for (var key in Security.SecurityPanelSidebarTree.OriginGroupName) {
var originGroupName = Security.SecurityPanelSidebarTree.OriginGroupName[key];
- var originGroup = new TreeElement(originGroupName, true);
+ var originGroup = new UI.TreeElement(originGroupName, true);
originGroup.selectable = false;
originGroup.expand();
originGroup.listItemElement.classList.add('security-sidebar-origins');
@@ -412,7 +412,7 @@ Security.SecurityPanelSidebarTree = class extends TreeOutlineInShadow {
this._clearOriginGroups();
// This message will be removed by clearOrigins() during the first new page load after the panel was opened.
- var mainViewReloadMessage = new TreeElement(Common.UIString('Reload to view details'));
+ var mainViewReloadMessage = new UI.TreeElement(Common.UIString('Reload to view details'));
mainViewReloadMessage.selectable = false;
mainViewReloadMessage.listItemElement.classList.add('security-main-view-reload-message');
this._originGroups.get(Security.SecurityPanelSidebarTree.OriginGroupName.MainOrigin)
@@ -520,7 +520,7 @@ Security.SecurityPanelSidebarTree.OriginGroupName = {
/**
* @unrestricted
*/
-Security.SecurityPanelSidebarTreeElement = class extends TreeElement {
+Security.SecurityPanelSidebarTreeElement = class extends UI.TreeElement {
/**
* @param {string} text
* @param {function()} selectCallback

Powered by Google App Engine
This is Rietveld 408576698