third_party/WebKit/Source/devtools/front_end/settings/EditFileSystemView.js - Issue 2604883002: DevTools: namespace globals

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/settings/EditFileSystemView.js

Issue 2604883002: DevTools: namespace globals (Closed)

Patch Set: address CL feedback Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/security/SecurityPanel.js ('k') | third_party/WebKit/Source/devtools/front_end/settings/FrameworkBlackboxSettingsTab.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/settings/EditFileSystemView.js

diff --git a/third_party/WebKit/Source/devtools/front_end/settings/EditFileSystemView.js b/third_party/WebKit/Source/devtools/front_end/settings/EditFileSystemView.js

index 9d4d9bd5ccd4d126b4dee49ebad1801c009f738a..5314a9e7f15e8f90085b285486970c18fe9b0536 100644

--- a/third_party/WebKit/Source/devtools/front_end/settings/EditFileSystemView.js

+++ b/third_party/WebKit/Source/devtools/front_end/settings/EditFileSystemView.js

@@ -68,7 +68,7 @@ Settings.EditFileSystemView = class extends UI.VBox {

} else {

mappingsPlaceholder.textContent = Common.UIString('No mappings');

mappingsHeader.appendChild(

- createTextButton(Common.UIString('Add'), this._addMappingButtonClicked.bind(this), 'add-button'));

+ UI.createTextButton(Common.UIString('Add'), this._addMappingButtonClicked.bind(this), 'add-button'));

}

this._mappingsList.setEmptyPlaceholder(mappingsPlaceholder);

this._mappingsList.show(this.contentElement);

@@ -77,7 +77,7 @@ Settings.EditFileSystemView = class extends UI.VBox {

excludedFoldersHeader.createChild('div', 'file-system-header-text').textContent =

Common.UIString('Excluded folders');

excludedFoldersHeader.appendChild(

- createTextButton(Common.UIString('Add'), this._addExcludedFolderButtonClicked.bind(this), 'add-button'));

+ UI.createTextButton(Common.UIString('Add'), this._addExcludedFolderButtonClicked.bind(this), 'add-button'));

this._excludedFoldersList = new UI.ListWidget(this);

this._excludedFoldersList.element.classList.add('file-system-list');

this._excludedFoldersList.registerRequiredCSS('settings/editFileSystemView.css');