Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Issue 2604843002: Fix crash in DirectoryImpl::Flush() (Closed)

Created:
3 years, 12 months ago by Marijn Kruisselbrink
Modified:
3 years, 11 months ago
Reviewers:
Elliot Glaysher, jam
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix crash in DirectoryImpl::Flush() BUG=None Committed: https://crrev.com/074906f973b5b08df264addfe0bc07e9114fcf6b Cr-Commit-Position: refs/heads/master@{#440858}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -1 line) Patch
M components/filesystem/directory_impl.cc View 1 chunk +2 lines, -1 line 0 comments Download
M components/filesystem/directory_impl_unittest.cc View 1 chunk +12 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 14 (9 generated)
Marijn Kruisselbrink
Not sure if this is actually the correct implementation of ::Flush, bit just passing FLAG_READ ...
3 years, 12 months ago (2016-12-27 19:29:27 UTC) #4
jam
lgtm
3 years, 12 months ago (2016-12-28 05:42:02 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2604843002/1
3 years, 11 months ago (2016-12-28 17:11:37 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
3 years, 11 months ago (2016-12-28 17:17:00 UTC) #12
commit-bot: I haz the power
3 years, 11 months ago (2017-01-02 15:49:18 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/074906f973b5b08df264addfe0bc07e9114fcf6b
Cr-Commit-Position: refs/heads/master@{#440858}

Powered by Google App Engine
This is Rietveld 408576698