Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(780)

Issue 2604813002: arc: Avoid showing browser window in ARC++ Kiosk session (Closed)

Created:
3 years, 11 months ago by Sergey Poromov
Modified:
3 years, 11 months ago
Reviewers:
xiyuan, Nikita (slow)
CC:
chromium-reviews, alemate+watch_chromium.org, achuith+watch_chromium.org, oshima+watch_chromium.org, davemoore+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

arc: Avoid showing browser window in ARC++ Kiosk session Chrome shouldn't be started for ARC++ Kiosk sessions. However, if it's not started at all before "kSilentLaunch" check, then bottom bar is shown. Starting Chrome silently avoid it and shows only blank wallpaper until app is started. As in future dedicated ARC++ Kiosk initialization flow with Splash Screen will be added, the issue should pass away together with it, but we need temporary fix for M56 launch. BUG=676185 TEST=Manual, Start ARC++ Kiosk sessions. Review-Url: https://codereview.chromium.org/2604813002 Cr-Commit-Position: refs/heads/master@{#441933} Committed: https://chromium.googlesource.com/chromium/src/+/cb48fcfad8b0f6de386bb5d45bfc1090b1601f8b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M chrome/browser/chromeos/login/users/chrome_user_manager_impl.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
Sergey Poromov
3 years, 11 months ago (2016-12-27 17:47:07 UTC) #4
xiyuan
lgtm
3 years, 11 months ago (2017-01-03 18:03:20 UTC) #7
Nikita (slow)
lgtm
3 years, 11 months ago (2017-01-06 13:44:42 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2604813002/1
3 years, 11 months ago (2017-01-06 13:44:59 UTC) #10
commit-bot: I haz the power
3 years, 11 months ago (2017-01-06 15:00:29 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/cb48fcfad8b0f6de386bb5d45bfc...

Powered by Google App Engine
This is Rietveld 408576698