Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(470)

Unified Diff: components/password_manager/core/browser/password_manager.cc

Issue 2604783002: Do not show the update bubble for sync credentials when a username is unknown. (Closed)
Patch Set: tiny fix Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/password_manager/core/browser/password_manager.cc
diff --git a/components/password_manager/core/browser/password_manager.cc b/components/password_manager/core/browser/password_manager.cc
index 2f4715b58af98b3a9e2a4198285a88d624a50b8a..dae39509e4784c5a57a1be4da5e45ef788fc86ff 100644
--- a/components/password_manager/core/browser/password_manager.cc
+++ b/components/password_manager/core/browser/password_manager.cc
@@ -677,15 +677,17 @@ void PasswordManager::OnLoginSuccessful() {
client_->GetStoreResultFilter()->ReportFormLoginSuccess(
*provisional_save_manager_);
- if (base::FeatureList::IsEnabled(features::kDropSyncCredential) &&
- !client_->GetStoreResultFilter()->ShouldSave(
- provisional_save_manager_->pending_credentials())) {
- provisional_save_manager_->WipeStoreCopyIfOutdated();
- RecordFailure(SYNC_CREDENTIAL,
- provisional_save_manager_->observed_form().origin,
- logger.get());
- provisional_save_manager_.reset();
- return;
+ if (base::FeatureList::IsEnabled(features::kDropSyncCredential)) {
+ DCHECK(provisional_save_manager_->provisionally_saved_form());
+ if (!client_->GetStoreResultFilter()->ShouldSave(
+ *provisional_save_manager_->provisionally_saved_form())) {
+ provisional_save_manager_->WipeStoreCopyIfOutdated();
+ RecordFailure(SYNC_CREDENTIAL,
+ provisional_save_manager_->observed_form().origin,
+ logger.get());
+ provisional_save_manager_.reset();
+ return;
+ }
}
provisional_save_manager_->LogSubmitPassed();

Powered by Google App Engine
This is Rietveld 408576698