Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10030)

Unified Diff: components/password_manager/core/browser/password_form_manager.cc

Issue 2604783002: Do not show the update bubble for sync credentials when a username is unknown. (Closed)
Patch Set: tiny fix Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/password_manager/core/browser/password_form_manager.cc
diff --git a/components/password_manager/core/browser/password_form_manager.cc b/components/password_manager/core/browser/password_form_manager.cc
index 4c82699add8cb06066c625d7f3ffc2397cd3dccd..ac7f3588cd54137b1b25b022cabfe655d4f4d3a1 100644
--- a/components/password_manager/core/browser/password_form_manager.cc
+++ b/components/password_manager/core/browser/password_form_manager.cc
@@ -1018,13 +1018,6 @@ void PasswordFormManager::CreatePendingCredentials() {
if (has_generated_password_)
pending_credentials_.type = PasswordForm::TYPE_GENERATED;
-
- // In case of change password forms we need to leave
- // |provisionally_saved_form_| in order to be able to determine which field is
- // password and which is a new password during sending a vote in other cases
- // we can reset |provisionally_saved_form_|.
- if (!provisionally_saved_form_->IsPossibleChangePasswordForm())
- provisionally_saved_form_.reset();
}
uint32_t PasswordFormManager::ScoreResult(const PasswordForm& candidate) const {

Powered by Google App Engine
This is Rietveld 408576698