Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Issue 2604743002: [SPInvalidation] Force subtree paint property update on css position change (Closed)

Created:
3 years, 12 months ago by Xianzhu
Modified:
3 years, 11 months ago
Reviewers:
chrishtr
CC:
blink-reviews, blink-reviews-layout_chromium.org, blink-reviews-paint_chromium.org, chromium-reviews, dshwang, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[SPInvalidation] Force subtree paint property update on css position change CSS position change may not affect paint properties of the object itself, but may affect paint properties of descendants. BUG=674623 TEST=All/ScrollAnchorTest.ExcludeAbsolutePositionThatSticksToViewport/0 TEST=All/PaintPropertyTreeBuilderTest.PositionChangeUpdateDescendantProperties/* CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Committed: https://crrev.com/81c78e614b8a82160e2e0403011eba4701d09784 Cr-Commit-Position: refs/heads/master@{#440761}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -11 lines) Patch
M third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp View 1 chunk +8 lines, -11 lines 0 comments Download
M third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilderTest.cpp View 1 chunk +27 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (11 generated)
Xianzhu
3 years, 12 months ago (2016-12-27 17:36:34 UTC) #8
chrishtr
lgtm
3 years, 12 months ago (2016-12-27 17:53:39 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2604743002/1
3 years, 12 months ago (2016-12-27 17:53:56 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
3 years, 12 months ago (2016-12-27 17:57:49 UTC) #14
commit-bot: I haz the power
3 years, 11 months ago (2017-01-02 15:46:24 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/81c78e614b8a82160e2e0403011eba4701d09784
Cr-Commit-Position: refs/heads/master@{#440761}

Powered by Google App Engine
This is Rietveld 408576698