Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Issue 2604603002: Add LOAD_DO_NOT_SEND_AUTH_DATA flag to the avatar fetcher. (Closed)

Created:
3 years, 12 months ago by vasilii
Modified:
3 years, 12 months ago
Reviewers:
battre
CC:
chromium-reviews, gcasto+watchlist_chromium.org, vabr+watchlistpasswordmanager_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add LOAD_DO_NOT_SEND_AUTH_DATA flag to the avatar fetcher. As discussed with rsleevi@ this is a quick fix that improves the situation. A longer term solution is to be discussed. BUG=675944 Committed: https://crrev.com/db776d1a2133ce046f21cec827ef4dea34fb4c6a Cr-Commit-Position: refs/heads/master@{#440634}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/browser/ui/passwords/account_avatar_fetcher.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (9 generated)
vasilii
Hi Dominic, please review the CL.
3 years, 12 months ago (2016-12-23 14:27:33 UTC) #5
battre
lgtm
3 years, 12 months ago (2016-12-23 14:40:31 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2604603002/1
3 years, 12 months ago (2016-12-23 14:41:08 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
3 years, 12 months ago (2016-12-23 15:49:57 UTC) #12
commit-bot: I haz the power
3 years, 12 months ago (2016-12-23 15:52:55 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/db776d1a2133ce046f21cec827ef4dea34fb4c6a
Cr-Commit-Position: refs/heads/master@{#440634}

Powered by Google App Engine
This is Rietveld 408576698