Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(351)

Issue 2604553002: [inspector] speculative avoid using debugger context as current in blink (Closed)

Created:
3 years, 12 months ago by kozy
Modified:
3 years, 12 months ago
Reviewers:
dgozman, Yang
CC:
v8-reviews_googlegroups.com, devtools-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[inspector] speculative avoid using debugger context as current in blink Now we run nested message loop with debugger context as current one. BUG=chromium:676749 R=yangguo@chromium.org,dgozman@chromium.org Review-Url: https://codereview.chromium.org/2604553002 Cr-Commit-Position: refs/heads/master@{#41937} Committed: https://chromium.googlesource.com/v8/v8/+/b571c6d1cea5b0513dfa748a6330c4cb8f4ca89e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M src/inspector/v8-debugger.cc View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
kozy
Yang, please take a look. Do we really need to run all code on pause ...
3 years, 12 months ago (2016-12-23 09:20:45 UTC) #1
Yang
On 2016/12/23 09:20:45, kozyatinskiy (OOO) wrote: > Yang, please take a look. > Do we ...
3 years, 12 months ago (2016-12-23 09:39:32 UTC) #2
Yang
On 2016/12/23 09:39:32, Yang wrote: > On 2016/12/23 09:20:45, kozyatinskiy (OOO) wrote: > > Yang, ...
3 years, 12 months ago (2016-12-23 09:39:40 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2604553002/1
3 years, 12 months ago (2016-12-23 09:53:41 UTC) #8
commit-bot: I haz the power
3 years, 12 months ago (2016-12-23 10:06:30 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/b571c6d1cea5b0513dfa748a6330c4cb8f4...

Powered by Google App Engine
This is Rietveld 408576698