Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(641)

Unified Diff: content/browser/android/web_contents_observer_proxy.h

Issue 2604543002: WebContentsObserver and TabObserver update for PlzNavigate (Closed)
Patch Set: Code with new API without any real hookup Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/android/web_contents_observer_proxy.h
diff --git a/content/browser/android/web_contents_observer_proxy.h b/content/browser/android/web_contents_observer_proxy.h
index e9545b2ce561a59e8084e9d4908577f8d8657b46..1fc84c6c968cb2b311b3156009f4980eedc54699 100644
--- a/content/browser/android/web_contents_observer_proxy.h
+++ b/content/browser/android/web_contents_observer_proxy.h
@@ -32,7 +32,6 @@ class WebContentsObserverProxy : public WebContentsObserver {
private:
void RenderViewReady() override;
void RenderProcessGone(base::TerminationStatus termination_status) override;
- void DidFinishNavigation(NavigationHandle* navigation_handle) override;
void DidStartLoading() override;
void DidStopLoading() override;
void DidFailProvisionalLoad(RenderFrameHost* render_frame_host,
@@ -62,6 +61,10 @@ class WebContentsObserverProxy : public WebContentsObserver {
RenderFrameHost* render_frame_host,
const GURL& url,
ui::PageTransition transition_type) override;
+
+ void DidStartNavigation(NavigationHandle* navigation_handle) override;
+ void DidFinishNavigation(NavigationHandle* navigation_handle) override;
+
void DidFinishLoad(RenderFrameHost* render_frame_host,
const GURL& validated_url) override;
void DocumentLoadedInFrame(RenderFrameHost* render_frame_host) override;

Powered by Google App Engine
This is Rietveld 408576698