Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1824)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/tab/TabWebContentsObserver.java

Issue 2604543002: WebContentsObserver and TabObserver update for PlzNavigate (Closed)
Patch Set: Code with new API without any real hookup Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/tab/TabWebContentsObserver.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/tab/TabWebContentsObserver.java b/chrome/android/java/src/org/chromium/chrome/browser/tab/TabWebContentsObserver.java
index 7fe6078f54e75e97ce5d998d8e3010b3929a6dc6..2cc836c598de265826d5adea196a2ccd0e62955f 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/tab/TabWebContentsObserver.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/tab/TabWebContentsObserver.java
@@ -147,12 +147,6 @@ public class TabWebContentsObserver extends WebContentsObserver {
}
@Override
- public void didFinishNavigation(
- boolean isMainFrame, boolean isErrorPage, boolean hasCommitted) {
- if (isMainFrame && hasCommitted) mTab.setIsShowingErrorPage(isErrorPage);
- }
-
- @Override
public void didFinishLoad(long frameId, String validatedUrl, boolean isMainFrame) {
if (isMainFrame) mTab.didFinishPageLoad();
PolicyAuditor auditor =
@@ -254,6 +248,26 @@ public class TabWebContentsObserver extends WebContentsObserver {
}
@Override
+ public void didStartNavigation(String url, boolean isInMainFrame, boolean isErrorPage) {
+ RewindableIterator<TabObserver> observers = mTab.getTabObservers();
+ while (observers.hasNext()) {
+ observers.next().onDidStartNavigation(mTab, url, isInMainFrame, isErrorPage);
+ }
+ }
+
+ @Override
+ public void didFinishNavigation(String url, boolean isInMainFrame, boolean isErrorPage,
+ boolean hasCommitted, boolean isSamePage, boolean isReload, int errorCode) {
+ if (isInMainFrame && hasCommitted) mTab.setIsShowingErrorPage(isErrorPage);
+
+ RewindableIterator<TabObserver> observers = mTab.getTabObservers();
+ while (observers.hasNext()) {
+ observers.next().onDidFinishNavigation(mTab, url, isInMainFrame, isErrorPage,
+ hasCommitted, isSamePage, isReload, errorCode);
+ }
+ }
+
+ @Override
public void didFirstVisuallyNonEmptyPaint() {
RewindableIterator<TabObserver> observers = mTab.getTabObservers();
while (observers.hasNext()) {

Powered by Google App Engine
This is Rietveld 408576698