Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2147)

Unified Diff: net/cert/ct_serialization_unittest.cc

Issue 2604513002: Optimize CT & OCSP handling code (Closed)
Patch Set: Review feedback round two Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/cert/ct_serialization_unittest.cc
diff --git a/net/cert/ct_serialization_unittest.cc b/net/cert/ct_serialization_unittest.cc
index be84d8f24dee1e59321b802685dfca451ba7925a..6ddb329b7c4b2b68230a8977ca8332c16eb96f18 100644
--- a/net/cert/ct_serialization_unittest.cc
+++ b/net/cert/ct_serialization_unittest.cc
@@ -141,7 +141,7 @@ TEST_F(CtSerializationTest, DecodesSCTList) {
base::StringPiece encoded("\x0\xa\x0\x3\x61\x62\x63\x0\x3\x64\x65\x66", 12);
std::vector<base::StringPiece> decoded;
- ASSERT_TRUE(ct::DecodeSCTList(&encoded, &decoded));
+ ASSERT_TRUE(ct::DecodeSCTList(encoded, &decoded));
ASSERT_STREQ("abc", decoded[0].data());
ASSERT_STREQ("def", decoded[1].data());
}
@@ -151,7 +151,7 @@ TEST_F(CtSerializationTest, FailsDecodingInvalidSCTList) {
base::StringPiece encoded("\x0\xa\x0\x3\x61\x62\x63\x0\x5\x64\x65\x66", 12);
std::vector<base::StringPiece> decoded;
- ASSERT_FALSE(ct::DecodeSCTList(&encoded, &decoded));
+ ASSERT_FALSE(ct::DecodeSCTList(encoded, &decoded));
}
TEST_F(CtSerializationTest, DecodesSignedCertificateTimestamp) {

Powered by Google App Engine
This is Rietveld 408576698