Optimize CT & OCSP handling code

net/cert/ct_serialization_unittest.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/cert/ct_serialization.h"
 
 #include <string>
 
 #include "base/files/file_path.h"
 #include "base/files/file_util.h"
@@ skipping 123 matching lines @@
   std::string expected_buffer(
       "\x0\x0\x0\x0\x1\x39\xFE\x35\x3C\xF5\x61\x62\x63\x0\x0", 15);
   EXPECT_EQ(expected_buffer, encoded);
 }
 
 TEST_F(CtSerializationTest, DecodesSCTList) {
   // Two items in the list: "abc", "def"
   base::StringPiece encoded("\x0\xa\x0\x3\x61\x62\x63\x0\x3\x64\x65\x66", 12);
   std::vector<base::StringPiece> decoded;
 
-  ASSERT_TRUE(ct::DecodeSCTList(&encoded, &decoded));
+  ASSERT_TRUE(ct::DecodeSCTList(encoded, &decoded));
   ASSERT_STREQ("abc", decoded[0].data());
   ASSERT_STREQ("def", decoded[1].data());
 }
 
 TEST_F(CtSerializationTest, FailsDecodingInvalidSCTList) {
   // A list with one item that's too short
   base::StringPiece encoded("\x0\xa\x0\x3\x61\x62\x63\x0\x5\x64\x65\x66", 12);
   std::vector<base::StringPiece> decoded;
 
-  ASSERT_FALSE(ct::DecodeSCTList(&encoded, &decoded));
+  ASSERT_FALSE(ct::DecodeSCTList(encoded, &decoded));
 }
 
 TEST_F(CtSerializationTest, DecodesSignedCertificateTimestamp) {
   std::string encoded_test_sct(ct::GetTestSignedCertificateTimestamp());
   base::StringPiece encoded_sct(encoded_test_sct);
 
   scoped_refptr<ct::SignedCertificateTimestamp> sct;
   ASSERT_TRUE(ct::DecodeSignedCertificateTimestamp(&encoded_sct, &sct));
   EXPECT_EQ(0, sct->version);
   EXPECT_EQ(ct::GetTestPublicKeyId(), sct->log_id);
@@ skipping 87 matching lines @@
   // Bytes 10-17 are tree size
   // Bytes 18-49 are sha256 root hash
   ASSERT_EQ(50u, encoded.length());
   std::string expected_buffer(
       "\x0\x1\x0\x0\x1\x45\x3c\x5f\xb8\x35\x0\x0\x0\x0\x0\x0\x0\x15", 18);
   expected_buffer.append(ct::GetSampleSTHSHA256RootHash());
   ASSERT_EQ(expected_buffer, encoded);
 }
 
 }  // namespace net