[promises] Move PromiseHasUserDefinedRejectHandler to c++

[promises] Move PromiseHasUserDefinedRejectHandler to c++

BUG=v8:5343
Review-Url: https://codereview.chromium.org/2604483002
Cr-Commit-Position: refs/heads/master@{#41947}
Committed: https://chromium.googlesource.com/v8/v8/+/0f5c69c5eded518dfd4af3d64b8bb2c8212826d4

[gsathya, 2016-12-22 22:48:02]

The CQ bit was checked by gsathya@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-22 22:48:12]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[gsathya, 2016-12-22 22:51:26]

The CQ bit was checked by gsathya@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-22 22:51:32]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-22 23:16:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-22 23:16:26]

Dry run: This issue passed the CQ dry run.

[gsathya, 2016-12-22 23:22:51]

Description was changed from

==========
[promises] Move debug code to c++

BUG=v8:5343
==========

to

==========
[promises] Move PromiseHasUserDefinedRejectHandler to c++

BUG=v8:5343
==========

[gsathya, 2016-12-22 23:22:51]

gsathya@chromium.org changed reviewers:
+ adamk@chromium.org

[gsathya, 2016-12-22 23:23:13]

gsathya@chromium.org changed reviewers:
+ yangguo@chromium.org

[Yang, 2016-12-23 08:40:08]

lgtm

https://codereview.chromium.org/2604483002/diff/20001/src/isolate.cc
File src/isolate.cc (right):

https://codereview.chromium.org/2604483002/diff/20001/src/isolate.cc#newcode1825
src/isolate.cc:1825: if (JSReceiver::GetProperty(handler,
key).ToHandle(&forwarding_handler)) {
Since we do not expect any getters or other side effects, we could also use
JSReceiver::GetDataProperty here and below.

https://codereview.chromium.org/2604483002/diff/20001/src/runtime/runtime-pro...
File src/runtime/runtime-promise.cc (right):

https://codereview.chromium.org/2604483002/diff/20001/src/runtime/runtime-pro...
src/runtime/runtime-promise.cc:291: HandleScope scope(isolate);
No need to create a handle scope here. And above as well. Turn that into a
SealHandleScope please.

[gsathya, 2016-12-23 17:31:33]

The CQ bit was checked by gsathya@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-23 17:31:45]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[gsathya, 2016-12-23 17:59:44]

https://codereview.chromium.org/2604483002/diff/20001/src/isolate.cc
File src/isolate.cc (right):

https://codereview.chromium.org/2604483002/diff/20001/src/isolate.cc#newcode1825
src/isolate.cc:1825: if (JSReceiver::GetProperty(handler,
key).ToHandle(&forwarding_handler)) {
On 2016/12/23 08:40:08, Yang wrote:
> Since we do not expect any getters or other side effects, we could also use
> JSReceiver::GetDataProperty here and below.

Done.

https://codereview.chromium.org/2604483002/diff/20001/src/runtime/runtime-pro...
File src/runtime/runtime-promise.cc (right):

https://codereview.chromium.org/2604483002/diff/20001/src/runtime/runtime-pro...
src/runtime/runtime-promise.cc:291: HandleScope scope(isolate);
On 2016/12/23 08:40:08, Yang wrote:
> No need to create a handle scope here. And above as well. Turn that into a
> SealHandleScope please.

Done.

[commit-bot: I haz the power, 2016-12-23 18:00:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-23 18:00:52]

Dry run: This issue passed the CQ dry run.

[gsathya, 2016-12-23 18:01:54]

The CQ bit was checked by gsathya@chromium.org

[gsathya, 2016-12-23 18:01:54]

The patchset sent to the CQ was uploaded after l-g-t-m from yangguo@chromium.org
Link to the patchset: https://codereview.chromium.org/2604483002/#ps40001
(title: "use getdataproperty")

[commit-bot: I haz the power, 2016-12-23 18:01:57]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-23 18:03:34]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1482516114360350,
"parent_rev": "1344e3a9caba4206758623630e3c3dd6872879e7", "commit_rev":
"0f5c69c5eded518dfd4af3d64b8bb2c8212826d4"}

[commit-bot: I haz the power, 2016-12-23 18:03:39]

Description was changed from

==========
[promises] Move PromiseHasUserDefinedRejectHandler to c++

BUG=v8:5343
==========

to

==========
[promises] Move PromiseHasUserDefinedRejectHandler to c++

BUG=v8:5343

Review-Url: https://codereview.chromium.org/2604483002
Cr-Commit-Position: refs/heads/master@{#41947}
Committed:
https://chromium.googlesource.com/v8/v8/+/0f5c69c5eded518dfd4af3d64b8bb2c8212...
==========

[commit-bot: I haz the power, 2016-12-23 18:03:40]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/v8/v8/+/0f5c69c5eded518dfd4af3d64b8bb2c8212...

[adamk, 2016-12-27 17:44:59]

https://codereview.chromium.org/2604483002/diff/40001/src/runtime/runtime-pro...
File src/runtime/runtime-promise.cc (right):

https://codereview.chromium.org/2604483002/diff/40001/src/runtime/runtime-pro...
src/runtime/runtime-promise.cc:284: CONVERT_ARG_HANDLE_CHECKED(JSPromise,
promise, 0);
When using SealHandleScope you don't want to create handles, so this should be

CONVERT_ARG_CHECKED

instead

https://codereview.chromium.org/2604483002/diff/40001/src/runtime/runtime-pro...
src/runtime/runtime-promise.cc:293: CONVERT_ARG_HANDLE_CHECKED(JSPromise,
promise, 0);
Same down here.