Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(423)

Issue 2604413002: No longer clean out main thread's heap for LSan's benefit. (Closed)

Created:
3 years, 11 months ago by sof
Modified:
3 years, 11 months ago
Reviewers:
oilpan-reviews, haraken
CC:
chromium-reviews, oilpan-reviews, Mads Ager (chromium), blink-reviews, kinuko+watch, kouhei+heap_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

No longer clean out main thread's heap for LSan's benefit. The extra GCing that cleanupMainThread() appears to be redundant, as LSan will have performed leak detection prior to the main thread shutting down. R= BUG=677684 Committed: https://crrev.com/c53d9f4af3d1f42cbf785ceab1139b61050f0e43 Cr-Commit-Position: refs/heads/master@{#441068}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -19 lines) Patch
M third_party/WebKit/Source/platform/heap/ThreadState.cpp View 1 chunk +0 lines, -19 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
sof
please take a look. I didn't detect any extra LSan leaks when trying this on ...
3 years, 11 months ago (2017-01-02 14:44:34 UTC) #4
haraken
LGTM
3 years, 11 months ago (2017-01-02 14:58:33 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2604413002/1
3 years, 11 months ago (2017-01-02 15:54:02 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
3 years, 11 months ago (2017-01-02 15:58:00 UTC) #12
commit-bot: I haz the power
3 years, 11 months ago (2017-01-02 16:00:00 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c53d9f4af3d1f42cbf785ceab1139b61050f0e43
Cr-Commit-Position: refs/heads/master@{#441068}

Powered by Google App Engine
This is Rietveld 408576698