Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(200)

Issue 2604403002: Add missing HeapCompact DCHECK(). (Closed)

Created:
3 years, 11 months ago by sof
Modified:
3 years, 11 months ago
Reviewers:
oilpan-reviews, haraken
CC:
chromium-reviews, oilpan-reviews, Mads Ager (chromium), blink-reviews, kinuko+watch, kouhei+heap_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add missing HeapCompact DCHECK(). R= BUG= Committed: https://crrev.com/b74c43beae6d639f60e43ddaee182fa5b4d384bb Cr-Commit-Position: refs/heads/master@{#441072}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M third_party/WebKit/Source/platform/heap/HeapCompact.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (5 generated)
sof
please take a look.
3 years, 11 months ago (2017-01-02 14:08:19 UTC) #2
haraken
LGTM
3 years, 11 months ago (2017-01-02 14:57:51 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2604403002/1
3 years, 11 months ago (2017-01-02 14:58:48 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
3 years, 11 months ago (2017-01-02 16:30:29 UTC) #8
commit-bot: I haz the power
3 years, 11 months ago (2017-01-02 16:33:01 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b74c43beae6d639f60e43ddaee182fa5b4d384bb
Cr-Commit-Position: refs/heads/master@{#441072}

Powered by Google App Engine
This is Rietveld 408576698