Issue 2604353002: Revert TouchDevice.hasAnySource optimization.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2604353002: Revert TouchDevice.hasAnySource optimization. (Closed)

Created:
3 years, 11 months ago by Tobias Sargeant

Modified:
3 years, 11 months ago

Reviewers:

CC:
chromium-reviews

Target Ref:
refs/pending/branch-heads/2924

Project:
chromium

Visibility:
Public.

Revert TouchDevice.hasAnySource optimization. Android InputDevice sources are not represented by single set bits, and so or'ing them together is not correct. BUG=672907 Review-Url: https://codereview.chromium.org/2594733002 Cr-Commit-Position: refs/heads/master@{#439834} (cherry picked from commit d1c093ed77175994ae746c380d331961aa755955) Committed: https://chromium.googlesource.com/chromium/src/+/c379ecf81d253ca191ca39e1639b5a3380aaf6a5

Created: 3 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -10 lines)			Patch
	M	ui/android/java/src/org/chromium/ui/base/TouchDevice.java	View		2 chunks	+9 lines, -10 lines	0 comments	Download

Total messages: 2 (1 generated)

Tobias Sargeant

3 years, 11 months ago (2017-01-01 20:17:42 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
c379ecf81d253ca191ca39e1639b5a3380aaf6a5.