Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(924)

Issue 2594733002: Revert TouchDevice.hasAnySource optimization. (Closed)

Created:
4 years ago by Tobias Sargeant
Modified:
4 years ago
Reviewers:
Theresa
CC:
chromium-reviews, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert TouchDevice.hasAnySource optimization. Android InputDevice sources are not represented by single set bits, and so or'ing them together is not correct. BUG=672907 Committed: https://crrev.com/d1c093ed77175994ae746c380d331961aa755955 Cr-Commit-Position: refs/heads/master@{#439834}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -10 lines) Patch
M ui/android/java/src/org/chromium/ui/base/TouchDevice.java View 2 chunks +9 lines, -10 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
Tobias Sargeant
Hi Theresa, Sorry for introducing this bug. Could you please take a look at the ...
4 years ago (2016-12-20 16:23:33 UTC) #2
Theresa
lgtm
4 years ago (2016-12-20 16:26:58 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2594733002/1
4 years ago (2016-12-20 16:44:00 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-20 17:25:35 UTC) #8
commit-bot: I haz the power
4 years ago (2016-12-20 17:29:24 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d1c093ed77175994ae746c380d331961aa755955
Cr-Commit-Position: refs/heads/master@{#439834}

Powered by Google App Engine
This is Rietveld 408576698