ui/views/controls/focus_ring.cc - Issue 2604303002: (Mac)Views: Widgets focus first View in traversal order if initial focus fails.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/views/controls/focus_ring.cc

Issue 2604303002: (Mac)Views: Widgets focus first View in traversal order if initial focus fails. (Closed)

Patch Set: Use views:: everywhere for consistency (?) Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ui/views/controls/focus_ring.cc

diff --git a/ui/views/controls/focus_ring.cc b/ui/views/controls/focus_ring.cc

index 29adfa0e2207a619b1310df98c028961dec85b54..c8985bf255dd65277b7950e73c0d4289c9998c1e 100644

--- a/ui/views/controls/focus_ring.cc

+++ b/ui/views/controls/focus_ring.cc

@@ -36,7 +36,6 @@ const char FocusRing::kViewClassName[] = "FocusRing";

// static

views::View* FocusRing::Install(views::View* parent,

ui::NativeTheme::ColorId override_color_id) {

- DCHECK(parent->HasFocus());

karandeepb 2016/12/30 21:16:04 If it's ok, can you send a separate CL for this, s

Patti Lor 2017/01/03 03:48:26 No worries, see https://codereview.chromium.org/26

FocusRing* ring = GetFocusRing(parent);

if (!ring) {

ring = new FocusRing();