Do not fetch a new config if one is already in progress.

Do not fetch a new config if one is already in progress.

Do not fetch a data reduction proxy config due to auth failure if the fetch
of the previous config is ongoing.

BUG=677569
Committed: https://crrev.com/0216e584179ebe2e4ca415930b916f2e76f1b559
Cr-Commit-Position: refs/heads/master@{#441179}

[tbansal1, 2016-12-29 23:34:18]

The CQ bit was checked by tbansal@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-29 23:34:30]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tbansal1, 2016-12-29 23:37:13]

Description was changed from

==========
Do not fetch a new config if one is already in progress.

Do not fetch a data reduction proxy config if the fetch of the previous
config is already ongoing.

BUG=
==========

to

==========
Do not fetch a new config if one is already in progress.

Do not fetch a data reduction proxy config if the fetch of the previous
config is already ongoing.

BUG=677569
==========

[tbansal1, 2016-12-29 23:37:30]

Description was changed from

==========
Do not fetch a new config if one is already in progress.

Do not fetch a data reduction proxy config if the fetch of the previous
config is already ongoing.

BUG=677569
==========

to

==========
Do not fetch a new config if one is already in progress.

Do not fetch a data reduction proxy config due to auth failure if the fetch 
of the previous config is ongoing.

BUG=677569
==========

[tbansal1, 2016-12-29 23:38:35]

tbansal@chromium.org changed reviewers:
+ ryansturm@chromium.org

[tbansal1, 2016-12-29 23:38:35]

ryansturm: ptal. Thanks.

[commit-bot: I haz the power, 2016-12-30 00:36:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-30 00:36:30]

Dry run: This issue passed the CQ dry run.

[RyanSturm, 2016-12-30 18:13:24]

lgtm % 2 nits

https://codereview.chromium.org/2604293002/diff/1/components/data_reduction_p...
File
components/data_reduction_proxy/core/browser/data_reduction_proxy_config_service_client.h
(right):

https://codereview.chromium.org/2604293002/diff/1/components/data_reduction_p...
components/data_reduction_proxy/core/browser/data_reduction_proxy_config_service_client.h:279:
// True if a client config fetch is in progress.
nit: personal preference: s/True if/Whether/

I know either way is all over the place, so feel free to ignore this; I just
prefer Whether.

https://codereview.chromium.org/2604293002/diff/1/components/data_reduction_p...
File
components/data_reduction_proxy/core/browser/data_reduction_proxy_config_service_client_unittest.cc
(right):

https://codereview.chromium.org/2604293002/diff/1/components/data_reduction_p...
components/data_reduction_proxy/core/browser/data_reduction_proxy_config_service_client_unittest.cc:878:
// RunUntilIdle();
Commented out code?

[tbansal1, 2017-01-03 17:40:12]

The CQ bit was checked by tbansal@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-03 17:40:29]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tbansal1, 2017-01-03 17:41:26]

https://codereview.chromium.org/2604293002/diff/1/components/data_reduction_p...
File
components/data_reduction_proxy/core/browser/data_reduction_proxy_config_service_client.h
(right):

https://codereview.chromium.org/2604293002/diff/1/components/data_reduction_p...
components/data_reduction_proxy/core/browser/data_reduction_proxy_config_service_client.h:279:
// True if a client config fetch is in progress.
On 2016/12/30 18:13:24, Ryan Sturm wrote:
> nit: personal preference: s/True if/Whether/
> 
> I know either way is all over the place, so feel free to ignore this; I just
> prefer Whether.

Ignoring :)

https://codereview.chromium.org/2604293002/diff/1/components/data_reduction_p...
File
components/data_reduction_proxy/core/browser/data_reduction_proxy_config_service_client_unittest.cc
(right):

https://codereview.chromium.org/2604293002/diff/1/components/data_reduction_p...
components/data_reduction_proxy/core/browser/data_reduction_proxy_config_service_client_unittest.cc:878:
// RunUntilIdle();
On 2016/12/30 18:13:24, Ryan Sturm wrote:
> Commented out code?

Done.

[jpfeiff, 2017-01-03 17:51:09]

jpfeiff@chromium.org changed reviewers:
+ jpfeiff@chromium.org

[jpfeiff, 2017-01-03 17:51:10]

https://codereview.chromium.org/2604293002/diff/20001/components/data_reducti...
File
components/data_reduction_proxy/core/browser/data_reduction_proxy_config_service_client.cc
(right):

https://codereview.chromium.org/2604293002/diff/20001/components/data_reducti...
components/data_reduction_proxy/core/browser/data_reduction_proxy_config_service_client.cc:421:
// |fetcher_| should not retry on network changes since a new fetch will be
s/fetcher_/fetcher

[tbansal1, 2017-01-03 18:10:10]

https://codereview.chromium.org/2604293002/diff/20001/components/data_reducti...
File
components/data_reduction_proxy/core/browser/data_reduction_proxy_config_service_client.cc
(right):

https://codereview.chromium.org/2604293002/diff/20001/components/data_reducti...
components/data_reduction_proxy/core/browser/data_reduction_proxy_config_service_client.cc:421:
// |fetcher_| should not retry on network changes since a new fetch will be
On 2017/01/03 17:51:09, jpfeiff wrote:
> s/fetcher_/fetcher

Done.

[tbansal1, 2017-01-03 18:10:14]

The CQ bit was checked by tbansal@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-03 18:10:38]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-03 19:09:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-03 19:09:06]

Dry run: This issue passed the CQ dry run.

[tbansal1, 2017-01-03 19:10:45]

The CQ bit was checked by tbansal@chromium.org

[tbansal1, 2017-01-03 19:10:45]

The patchset sent to the CQ was uploaded after l-g-t-m from
ryansturm@chromium.org
Link to the patchset: https://codereview.chromium.org/2604293002/#ps40001
(title: "jpfeiff comments")

[commit-bot: I haz the power, 2017-01-03 19:11:03]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-03 19:15:33]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1483470645543100,
"parent_rev": "d13c955121552842083258b7b67f95296f24b54e", "commit_rev":
"c76b60569271a5ebff80a87cf8df5352c838bd7e"}

[commit-bot: I haz the power, 2017-01-03 19:16:00]

Description was changed from

==========
Do not fetch a new config if one is already in progress.

Do not fetch a data reduction proxy config due to auth failure if the fetch 
of the previous config is ongoing.

BUG=677569
==========

to

==========
Do not fetch a new config if one is already in progress.

Do not fetch a data reduction proxy config due to auth failure if the fetch 
of the previous config is ongoing.

BUG=677569

Review-Url: https://codereview.chromium.org/2604293002
==========

[commit-bot: I haz the power, 2017-01-03 19:16:01]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2017-01-03 19:19:31]

Description was changed from

==========
Do not fetch a new config if one is already in progress.

Do not fetch a data reduction proxy config due to auth failure if the fetch 
of the previous config is ongoing.

BUG=677569

Review-Url: https://codereview.chromium.org/2604293002
==========

to

==========
Do not fetch a new config if one is already in progress.

Do not fetch a data reduction proxy config due to auth failure if the fetch
of the previous config is ongoing.

BUG=677569

Committed: https://crrev.com/0216e584179ebe2e4ca415930b916f2e76f1b559
Cr-Commit-Position: refs/heads/master@{#441179}
==========

[commit-bot: I haz the power, 2017-01-03 19:19:32]

Patchset 3 (id:??) landed as
https://crrev.com/0216e584179ebe2e4ca415930b916f2e76f1b559
Cr-Commit-Position: refs/heads/master@{#441179}