[csa] Refactor promises API

src/builtins/builtins-promise.h

Index: src/builtins/builtins-promise.h
diff --git a/src/builtins/builtins-promise.h b/src/builtins/builtins-promise.h
index 4ceedfac22b11e56a36ca0af0c41604ec711cfbb..72dfc94ea75ad414e254c43a5072af545d01fc4d 100644
--- a/src/builtins/builtins-promise.h
+++ b/src/builtins/builtins-promise.h
@@ -16,7 +16,9 @@ class PromiseBuiltinsAssembler : public CodeStubAssembler {
   explicit PromiseBuiltinsAssembler(CodeAssemblerState* state)
       : CodeStubAssembler(state) {}
 
-  Node* AllocateAndInitPromise(Node* context, Node* parent);
+  Node* AllocateAndInitJSPromise(Node* context);

[adamk, 2017/01/03 23:26:10]

Please add some comments explaining the difference between these; in particular
it's not obvious what "Init" means vs "Set"

[gsathya, 2017/01/04 01:22:37]

Done.

+  Node* AllocateAndInitJSPromise(Node* context, Node* parent);
+  Node* AllocateAndSetJSPromise(Node* context, Node* status, Node* result);
 
   Node* ThrowIfNotJSReceiver(Node* context, Node* value,
                              MessageTemplate::Template msg_template);
@@ -57,6 +59,10 @@ class PromiseBuiltinsAssembler : public CodeStubAssembler {
 
   Node* NewPromiseCapability(Node* context, Node* constructor,
                              Node* debug_event = nullptr);
+
+ protected:

[adamk, 2017/01/03 23:26:10]

Can these be private?

[gsathya, 2017/01/04 01:22:37]

Moved allocatejspromise to be private. PromiseInit is used in a builtin (which
is a subclass of PromiseBuiltinsAssembler) so can't be private

+  Node* AllocateJSPromise(Node* context);
+  void PromiseInit(Node* promise);
 };
 
 }  // namespace internal