Chromium Code Reviews

Unified Diff: src/builtins/builtins-promise.h

Issue 2604273003: [csa] Refactor promises API (Closed)
Patch Set: remove CSA::Promises API Created 3 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
« no previous file with comments | « no previous file | src/builtins/builtins-promise.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/builtins/builtins-promise.h
diff --git a/src/builtins/builtins-promise.h b/src/builtins/builtins-promise.h
index 4ceedfac22b11e56a36ca0af0c41604ec711cfbb..72dfc94ea75ad414e254c43a5072af545d01fc4d 100644
--- a/src/builtins/builtins-promise.h
+++ b/src/builtins/builtins-promise.h
@@ -16,7 +16,9 @@ class PromiseBuiltinsAssembler : public CodeStubAssembler {
explicit PromiseBuiltinsAssembler(CodeAssemblerState* state)
: CodeStubAssembler(state) {}
- Node* AllocateAndInitPromise(Node* context, Node* parent);
+ Node* AllocateAndInitJSPromise(Node* context);
adamk 2017/01/03 23:26:10 Please add some comments explaining the difference
gsathya 2017/01/04 01:22:37 Done.
+ Node* AllocateAndInitJSPromise(Node* context, Node* parent);
+ Node* AllocateAndSetJSPromise(Node* context, Node* status, Node* result);
Node* ThrowIfNotJSReceiver(Node* context, Node* value,
MessageTemplate::Template msg_template);
@@ -57,6 +59,10 @@ class PromiseBuiltinsAssembler : public CodeStubAssembler {
Node* NewPromiseCapability(Node* context, Node* constructor,
Node* debug_event = nullptr);
+
+ protected:
adamk 2017/01/03 23:26:10 Can these be private?
gsathya 2017/01/04 01:22:37 Moved allocatejspromise to be private. PromiseInit
+ Node* AllocateJSPromise(Node* context);
+ void PromiseInit(Node* promise);
};
} // namespace internal
« no previous file with comments | « no previous file | src/builtins/builtins-promise.cc » ('j') | no next file with comments »

Powered by Google App Engine