[csa] Refactor promises API

src/builtins/builtins-promise.h

 // Copyright 2016 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/code-stub-assembler.h"
 
 namespace v8 {
 namespace internal {
 
 typedef compiler::Node Node;
 typedef CodeStubAssembler::ParameterMode ParameterMode;
 typedef compiler::CodeAssemblerState CodeAssemblerState;
 
 class PromiseBuiltinsAssembler : public CodeStubAssembler {
  public:
   explicit PromiseBuiltinsAssembler(CodeAssemblerState* state)
       : CodeStubAssembler(state) {}
 
-  Node* AllocateAndInitPromise(Node* context, Node* parent);
+  Node* AllocateAndInitJSPromise(Node* context);

[adamk, 2017/01/03 23:26:10]

Please add some comments explaining the difference between these; in particular
it's not obvious what "Init" means vs "Set"

[gsathya, 2017/01/04 01:22:37]

Done.

+  Node* AllocateAndInitJSPromise(Node* context, Node* parent);
+  Node* AllocateAndSetJSPromise(Node* context, Node* status, Node* result);
 
   Node* ThrowIfNotJSReceiver(Node* context, Node* value,
                              MessageTemplate::Template msg_template);
 
   Node* SpeciesConstructor(Node* context, Node* object,
                            Node* default_constructor);
 
   Node* PromiseHasHandler(Node* promise);
 
   void PromiseSetHasHandler(Node* promise);
@@ skipping 20 matching lines @@
                                                Node* native_context);
 
   std::pair<Node*, Node*> CreatePromiseResolvingFunctions(
       Node* promise, Node* native_context, Node* promise_context);
 
   Node* CreatePromiseGetCapabilitiesExecutorContext(Node* native_context,
                                                     Node* promise_capability);
 
   Node* NewPromiseCapability(Node* context, Node* constructor,
                              Node* debug_event = nullptr);
+
+ protected:

[adamk, 2017/01/03 23:26:10]

Can these be private?

[gsathya, 2017/01/04 01:22:37]

Moved allocatejspromise to be private. PromiseInit is used in a builtin (which
is a subclass of PromiseBuiltinsAssembler) so can't be private

+  Node* AllocateJSPromise(Node* context);
+  void PromiseInit(Node* promise);
 };
 
 }  // namespace internal
 }  // namespace v8