Add Physical Web omnibox support for Android

Add Physical Web omnibox support for Android

This adds some degree of feature parity with iOS, which also has a
Physical Web omnibox completion and zero-suggest feature.

BUG=663842
Review-Url: https://codereview.chromium.org/2604243002
Cr-Commit-Position: refs/heads/master@{#442024}
Committed: https://chromium.googlesource.com/chromium/src/+/cec11b6fe6c552ebe75b2b67f4eb20aab167621b

[cco3, 2016-12-29 22:30:58]

cco3@chromium.org changed reviewers:
+ mattreynolds@chromium.org

[cco3, 2016-12-29 22:30:59]

Please note that this change is dependent on
https://codereview.chromium.org/2603043002/ (which must be merged first)

[mattreynolds, 2017-01-04 01:29:29]

lgtm

[cco3, 2017-01-04 17:21:56]

cco3@chromium.org changed reviewers:
+ mpearson@chromium.org

[cco3, 2017-01-04 17:30:47]

cco3@chromium.org changed reviewers:
+ jam@chromium.org, mariakhomenko@chromium.org

[cco3, 2017-01-04 17:30:47]

jam@, would you be able to review the two url_constant files?

mariakhomenko@, would you be able to review the
autocomplete_controller_android.cc change?

[Maria, 2017-01-04 17:57:55]

On 2017/01/04 17:30:47, cco3 wrote:
> jam@, would you be able to review the two url_constant files?
> 
> mariakhomenko@, would you be able to review the
> autocomplete_controller_android.cc change?

What is the new expected behaviour with the Physical Web provider? I didn't see
any details in the bug.

[mattreynolds, 2017-01-04 19:56:42]

On 2017/01/04 17:57:55, Maria wrote:
> On 2017/01/04 17:30:47, cco3 wrote:
> > jam@, would you be able to review the two url_constant files?
> > 
> > mariakhomenko@, would you be able to review the
> > autocomplete_controller_android.cc change?
> 
> What is the new expected behaviour with the Physical Web provider? I didn't
see
> any details in the bug.

Hi Maria, I replied to the bug with a link to a doc that describes the feature.

[Maria, 2017-01-04 21:30:50]

lgtm

[cco3, 2017-01-04 21:50:00]

Thank you!

[jam, 2017-01-05 16:09:20]

why is the url constant in content/ instead of chrome?

[cco3, 2017-01-05 18:25:02]

On 2017/01/05 16:09:20, jam wrote:
> why is the url constant in content/ instead of chrome?

I thought it would make sense to put kChromeUINativeScheme next to
kChromeUIScheme, but there's already one in chrome::, so I'll just use that.

[Mark P, 2017-01-05 19:52:31]

lgtm with minor comments

--mark

https://codereview.chromium.org/2604243002/diff/20001/components/omnibox/brow...
File components/omnibox/browser/autocomplete_classifier.cc (right):

https://codereview.chromium.org/2604243002/diff/20001/components/omnibox/brow...
components/omnibox/browser/autocomplete_classifier.cc:21:
AutocompleteProvider::TYPE_PHYSICAL_WEB |
Please comment, e.g., is this here because it's not implemented on desktop or
because it's a product decision or ...

https://codereview.chromium.org/2604243002/diff/20001/components/omnibox/brow...
components/omnibox/browser/autocomplete_classifier.cc:23: // Custom search
engines cannot be used on mobile..
nit: please remove the extra period while you're here.

[cco3, 2017-01-05 20:24:06]

https://codereview.chromium.org/2604243002/diff/20001/components/omnibox/brow...
File components/omnibox/browser/autocomplete_classifier.cc (right):

https://codereview.chromium.org/2604243002/diff/20001/components/omnibox/brow...
components/omnibox/browser/autocomplete_classifier.cc:21:
AutocompleteProvider::TYPE_PHYSICAL_WEB |
On 2017/01/05 19:52:31, Mark P wrote:
> Please comment, e.g., is this here because it's not implemented on desktop or
> because it's a product decision or ...

Done.

https://codereview.chromium.org/2604243002/diff/20001/components/omnibox/brow...
components/omnibox/browser/autocomplete_classifier.cc:23: // Custom search
engines cannot be used on mobile..
On 2017/01/05 19:52:31, Mark P wrote:
> nit: please remove the extra period while you're here.

Done.

[cco3, 2017-01-06 18:37:00]

The CQ bit was checked by cco3@chromium.org

[cco3, 2017-01-06 18:37:00]

The patchset sent to the CQ was uploaded after l-g-t-m from
mariakhomenko@chromium.org, mattreynolds@chromium.org, mpearson@chromium.org
Link to the patchset: https://codereview.chromium.org/2604243002/#ps60001
(title: "Remove comments change")

[commit-bot: I haz the power, 2017-01-06 18:37:33]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-06 20:15:26]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1483727820000830,
"parent_rev": "09884beef8d9c585d4debd606c394bbd68e44ad5", "commit_rev":
"cec11b6fe6c552ebe75b2b67f4eb20aab167621b"}

[commit-bot: I haz the power, 2017-01-06 20:15:54]

Description was changed from

==========
Add Physical Web omnibox support for Android

This adds some degree of feature parity with iOS, which also has a
Physical Web omnibox completion and zero-suggest feature.

BUG=663842
==========

to

==========
Add Physical Web omnibox support for Android

This adds some degree of feature parity with iOS, which also has a
Physical Web omnibox completion and zero-suggest feature.

BUG=663842

Review-Url: https://codereview.chromium.org/2604243002
Cr-Commit-Position: refs/heads/master@{#442024}
Committed:
https://chromium.googlesource.com/chromium/src/+/cec11b6fe6c552ebe75b2b67f4eb...
==========

[commit-bot: I haz the power, 2017-01-06 20:15:56]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/cec11b6fe6c552ebe75b2b67f4eb...