Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(322)

Issue 2604213002: When auto-importing, don't limit rebaselining to directly modified tests. (Closed)

Created:
3 years, 11 months ago by qyearsley
Modified:
3 years, 11 months ago
Reviewers:
wkorman
CC:
blink-reviews, blink-reviews-w3ctests_chromium.org, chromium-reviews, Dirk Pranke, jsbell, tkent
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

When auto-importing, don't limit rebaselining to directly modified tests. BUG=676196 Review-Url: https://codereview.chromium.org/2604213002 Cr-Commit-Position: refs/heads/master@{#443417} Committed: https://chromium.googlesource.com/chromium/src/+/456acc90587baec5eac79f0273d46145f6712cf7

Patch Set 1 #

Patch Set 2 : Rebased #

Patch Set 3 : Update test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -42 lines) Patch
M third_party/WebKit/Tools/Scripts/webkitpy/w3c/update_w3c_test_expectations.py View 1 4 chunks +5 lines, -24 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/w3c/update_w3c_test_expectations_unittest.py View 1 2 5 chunks +4 lines, -18 lines 0 comments Download

Messages

Total messages: 21 (16 generated)
qyearsley
Rebased
3 years, 11 months ago (2017-01-03 22:19:28 UTC) #5
qyearsley
The purpose of this CL is to prevent the W3C test autoroller from adding lines ...
3 years, 11 months ago (2017-01-12 22:35:31 UTC) #13
wkorman
lgtm
3 years, 11 months ago (2017-01-12 23:19:29 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2604213002/40001
3 years, 11 months ago (2017-01-13 00:20:06 UTC) #18
commit-bot: I haz the power
3 years, 11 months ago (2017-01-13 00:45:57 UTC) #21
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/456acc90587baec5eac79f0273d4...

Powered by Google App Engine
This is Rietveld 408576698