Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2604163003:
Implement PaintArtifactCompositor::mightOverlap. (Closed)
|
Created:
3 years, 11 months ago by chrishtr Modified:
3 years, 11 months ago Reviewers:
wkorman CC:
ajuma+watch_chromium.org, blink-reviews, blink-reviews-platform-graphics_chromium.org, Rik, chromium-reviews, danakj+watch_chromium.org, dshwang, drott+blinkwatch_chromium.org, krit, f(malita), jbroman, Justin Novosad, kinuko+watch, pdr+graphicswatchlist_chromium.org, rwlbuis, Stephen Chennney Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionImplement PaintArtifactCompositor::mightOverlap.
BUG=668342
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Committed: https://crrev.com/409105d99bad5d8f18a0abbbe22caf1db9eeb8ba
Cr-Commit-Position: refs/heads/master@{#440988}
Patch Set 1 #Patch Set 2 : none #
Total comments: 1
Patch Set 3 : none #
Total comments: 2
Messages
Total messages: 24 (18 generated)
Description was changed from ========== none none BUG= ========== to ========== none none BUG= CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 ==========
The CQ bit was checked by chrishtr@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== none none BUG= CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 ========== to ========== Implement PAC::mightOverlap. BUG=668342 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 ==========
The CQ bit was unchecked by chrishtr@chromium.org
The CQ bit was checked by chrishtr@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Implement PAC::mightOverlap. BUG=668342 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 ========== to ========== Implement PaintArtifactCompositor::mightOverlap. BUG=668342 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 ==========
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by chrishtr@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
chrishtr@chromium.org changed reviewers: + wkorman@chromium.org
https://codereview.chromium.org/2604163003/diff/20001/third_party/WebKit/Sour... File third_party/WebKit/Source/platform/graphics/compositing/PaintArtifactCompositorTest.cpp (right): https://codereview.chromium.org/2604163003/diff/20001/third_party/WebKit/Sour... third_party/WebKit/Source/platform/graphics/compositing/PaintArtifactCompositorTest.cpp:569: .foreignLayer(FloatPoint(50, 60), IntSize(400, 300), layer); Changed this to ensure overlap.
lgtm https://codereview.chromium.org/2604163003/diff/40001/third_party/WebKit/Sour... File third_party/WebKit/Source/platform/graphics/compositing/PaintArtifactCompositor.cpp (right): https://codereview.chromium.org/2604163003/diff/40001/third_party/WebKit/Sour... third_party/WebKit/Source/platform/graphics/compositing/PaintArtifactCompositor.cpp:1044: PropertyTreeState rootPropertyTreeState( nit: could be worth adding a static instance for this, following what we do for the root nodes themselves. We use this in a few other places already though they're all tests until this case. Could replace those with this if we had it, but mainly, might make overlap tests a bit faster since we wouldn't need to construct each time. Premature optimization, etc.
https://codereview.chromium.org/2604163003/diff/40001/third_party/WebKit/Sour... File third_party/WebKit/Source/platform/graphics/compositing/PaintArtifactCompositor.cpp (right): https://codereview.chromium.org/2604163003/diff/40001/third_party/WebKit/Sour... third_party/WebKit/Source/platform/graphics/compositing/PaintArtifactCompositor.cpp:1044: PropertyTreeState rootPropertyTreeState( On 2016/12/29 at 19:49:40, wkorman wrote: > nit: could be worth adding a static instance for this, following what we do for the root nodes themselves. We use this in a few other places already though they're all tests until this case. Could replace those with this if we had it, but mainly, might make overlap tests a bit faster since we wouldn't need to construct each time. Premature optimization, etc. Good idea. I have a cleanup CL for PaintArtifactCompositorTest queued up that is sort of related to this, will this change to it.
The CQ bit was unchecked by chrishtr@chromium.org
The CQ bit was checked by chrishtr@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 40001, "attempt_start_ts": 1483041160619450,
"parent_rev": "6a06e3bc70d7d1aff9d5c368e6a50615e00e0d9c", "commit_rev":
"483075d9d079f66c957dc09ea0152cafec853cb7"}
Message was sent while issue was closed.
Description was changed from ========== Implement PaintArtifactCompositor::mightOverlap. BUG=668342 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 ========== to ========== Implement PaintArtifactCompositor::mightOverlap. BUG=668342 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Review-Url: https://codereview.chromium.org/2604163003 ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== Implement PaintArtifactCompositor::mightOverlap. BUG=668342 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Review-Url: https://codereview.chromium.org/2604163003 ========== to ========== Implement PaintArtifactCompositor::mightOverlap. BUG=668342 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Committed: https://crrev.com/409105d99bad5d8f18a0abbbe22caf1db9eeb8ba Cr-Commit-Position: refs/heads/master@{#440988} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/409105d99bad5d8f18a0abbbe22caf1db9eeb8ba Cr-Commit-Position: refs/heads/master@{#440988} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
