Don't mark virtual keyboard events as synthesized or distinguish between

Don't mark virtual keyboard events as synthesized or distinguish between
synthesized and non for Alt+Tab events.

This fixes a DCHECK in input_method_chromeos.cc and perhaps Alt+Tab's
interaction with input.ime.sendKeyEvents.

BUG=638269
Review-Url: https://codereview.chromium.org/2604093003
Cr-Commit-Position: refs/heads/master@{#442409}
Committed: https://chromium.googlesource.com/chromium/src/+/e97a4d2564c7ff2c4419164a119ec3d2424f7420

[Evan Stade, 2016-12-29 21:49:22]

estade@chromium.org changed reviewers:
+ oshima@chromium.org, yhanada@chromium.org

[Evan Stade, 2016-12-29 21:49:27]

The CQ bit was checked by estade@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-29 21:49:48]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-29 22:20:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-29 22:20:27]

Dry run: This issue passed the CQ dry run.

[oshima, 2017-01-05 22:11:35]

lgtm

https://codereview.chromium.org/2604093003/diff/1/ash/common/accelerators/acc...
File ash/common/accelerators/accelerator_controller.cc (right):

https://codereview.chromium.org/2604093003/diff/1/ash/common/accelerators/acc...
ash/common/accelerators/accelerator_controller.cc:176: return
!(keyboard_controller && keyboard_controller->keyboard_visible());
Hmm that's unfortunate.

Could you please add comment that this will disable alt-tab on real keyboard
when it's visible, but it's WAI due to IME implementation?

[Evan Stade, 2017-01-06 19:37:51]

https://codereview.chromium.org/2604093003/diff/1/ash/common/accelerators/acc...
File ash/common/accelerators/accelerator_controller.cc (right):

https://codereview.chromium.org/2604093003/diff/1/ash/common/accelerators/acc...
ash/common/accelerators/accelerator_controller.cc:176: return
!(keyboard_controller && keyboard_controller->keyboard_visible());
On 2017/01/05 22:11:35, oshima wrote:
> Hmm that's unfortunate.
> 
> Could you please add comment that this will disable alt-tab on real keyboard
> when it's visible, but it's WAI due to IME implementation?

Done.

[Evan Stade, 2017-01-06 19:39:07]

estade@chromium.org changed reviewers:
+ bshe@chromium.org

[Evan Stade, 2017-01-06 19:39:07]

+bshe for virtual_keyboard_private

[Evan Stade, 2017-01-06 19:40:57]

The CQ bit was checked by estade@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-06 19:41:41]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-06 20:22:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-06 20:22:58]

Dry run: This issue passed the CQ dry run.

[Evan Stade, 2017-01-09 20:54:37]

On 2017/01/06 19:39:07, Evan Stade wrote:
> +bshe for virtual_keyboard_private

ping

[bshe, 2017-01-09 21:53:07]

On 2017/01/09 20:54:37, Evan Stade wrote:
> On 2017/01/06 19:39:07, Evan Stade wrote:
> > +bshe for virtual_keyboard_private
> 
> ping

lgtm

[Evan Stade, 2017-01-09 22:56:08]

The CQ bit was checked by estade@chromium.org

[Evan Stade, 2017-01-09 22:56:09]

The patchset sent to the CQ was uploaded after l-g-t-m from oshima@chromium.org
Link to the patchset: https://codereview.chromium.org/2604093003/#ps20001
(title: "longer docs")

[commit-bot: I haz the power, 2017-01-09 22:56:41]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-10 00:08:21]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1484002568790780,
"parent_rev": "6f52f71437d12c64d03280ad7f528dbca9b321b4", "commit_rev":
"e97a4d2564c7ff2c4419164a119ec3d2424f7420"}

[commit-bot: I haz the power, 2017-01-10 00:08:53]

Description was changed from

==========
Don't mark virtual keyboard events as synthesized or distinguish between
synthesized and non for Alt+Tab events.

This fixes a DCHECK in input_method_chromeos.cc and perhaps Alt+Tab's
interaction with input.ime.sendKeyEvents.

BUG=638269
==========

to

==========
Don't mark virtual keyboard events as synthesized or distinguish between
synthesized and non for Alt+Tab events.

This fixes a DCHECK in input_method_chromeos.cc and perhaps Alt+Tab's
interaction with input.ime.sendKeyEvents.

BUG=638269

Review-Url: https://codereview.chromium.org/2604093003
Cr-Commit-Position: refs/heads/master@{#442409}
Committed:
https://chromium.googlesource.com/chromium/src/+/e97a4d2564c7ff2c4419164a119e...
==========

[commit-bot: I haz the power, 2017-01-10 00:08:57]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/e97a4d2564c7ff2c4419164a119e...