Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2604093002:
Add unittests for the bugs found in previous CL. (Closed)
|
Created:
3 years, 11 months ago by chrishtr Modified:
3 years, 11 months ago CC:
ajuma+watch_chromium.org, blink-reviews, blink-reviews-platform-graphics_chromium.org, Rik, chromium-reviews, danakj+watch_chromium.org, dshwang, drott+blinkwatch_chromium.org, krit, f(malita), jbroman, Justin Novosad, kinuko+watch, pdr+graphicswatchlist_chromium.org, rwlbuis, Stephen Chennney Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionAdd unittests for the bugs found in previous CL.
See comment 64:
https://codereview.chromium.org/2581843002#msg64
BUG=668342
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Committed: https://crrev.com/f87bb0ed27a65785ebd3bedf611ff66622b9c83a
Cr-Commit-Position: refs/heads/master@{#441008}
Patch Set 1 #Patch Set 2 : none #Patch Set 3 : none #
Total comments: 2
Patch Set 4 : none #Patch Set 5 : none #Patch Set 6 : none #
Messages
Total messages: 30 (20 generated)
Description was changed from ========== none none BUG= ========== to ========== none none BUG= CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 ==========
Description was changed from ========== none none BUG= CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 ========== to ========== Add unittests for the bugs found in previous CL. See comment 64: https://codereview.chromium.org/2581843002#msg64 BUG=668342 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 ==========
The CQ bit was checked by chrishtr@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
chrishtr@chromium.org changed reviewers: + trchen@chromium.org
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by chrishtr@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
ping
chrishtr@chromium.org changed reviewers: + wkorman@chromium.org
lgtm https://codereview.chromium.org/2604093002/diff/40001/third_party/WebKit/Sour... File third_party/WebKit/Source/platform/graphics/compositing/PaintArtifactCompositorTest.cpp (right): https://codereview.chromium.org/2604093002/diff/40001/third_party/WebKit/Sour... third_party/WebKit/Source/platform/graphics/compositing/PaintArtifactCompositorTest.cpp:1332: // Tests merging of an element which has two clips in the root Is this comment accurate? The method name and code seem to be two transforms with one clip between.
https://codereview.chromium.org/2604093002/diff/40001/third_party/WebKit/Sour... File third_party/WebKit/Source/platform/graphics/compositing/PaintArtifactCompositorTest.cpp (right): https://codereview.chromium.org/2604093002/diff/40001/third_party/WebKit/Sour... third_party/WebKit/Source/platform/graphics/compositing/PaintArtifactCompositorTest.cpp:1332: // Tests merging of an element which has two clips in the root On 2016/12/29 at 21:56:18, wkorman wrote: > Is this comment accurate? The method name and code seem to be two transforms with one clip between. Removed.
The CQ bit was checked by chrishtr@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from wkorman@chromium.org Link to the patchset: https://codereview.chromium.org/2604093002/#ps60001 (title: "none")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...) ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...) ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
The CQ bit was checked by chrishtr@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from wkorman@chromium.org Link to the patchset: https://codereview.chromium.org/2604093002/#ps100001 (title: "none")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 100001, "attempt_start_ts": 1483050628960430,
"parent_rev": "9ff17f6409abfd82e2cf2e654eadf1c03f70466a", "commit_rev":
"fedfe06569c2204a6f5523c1a9777fcfbc799bca"}
Message was sent while issue was closed.
Description was changed from ========== Add unittests for the bugs found in previous CL. See comment 64: https://codereview.chromium.org/2581843002#msg64 BUG=668342 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 ========== to ========== Add unittests for the bugs found in previous CL. See comment 64: https://codereview.chromium.org/2581843002#msg64 BUG=668342 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Review-Url: https://codereview.chromium.org/2604093002 ==========
Message was sent while issue was closed.
Committed patchset #6 (id:100001)
Message was sent while issue was closed.
Description was changed from ========== Add unittests for the bugs found in previous CL. See comment 64: https://codereview.chromium.org/2581843002#msg64 BUG=668342 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Review-Url: https://codereview.chromium.org/2604093002 ========== to ========== Add unittests for the bugs found in previous CL. See comment 64: https://codereview.chromium.org/2581843002#msg64 BUG=668342 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Committed: https://crrev.com/f87bb0ed27a65785ebd3bedf611ff66622b9c83a Cr-Commit-Position: refs/heads/master@{#441008} ==========
Message was sent while issue was closed.
Patchset 6 (id:??) landed as https://crrev.com/f87bb0ed27a65785ebd3bedf611ff66622b9c83a Cr-Commit-Position: refs/heads/master@{#441008} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
