Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Issue 2604083002: Remove infinite clip in PaintArtifactCompositor. (Closed)

Created:
3 years, 11 months ago by chrishtr
Modified:
3 years, 11 months ago
Reviewers:
wkorman
CC:
ajuma+watch_chromium.org, blink-reviews, blink-reviews-platform-graphics_chromium.org, Rik, chromium-reviews, danakj+watch_chromium.org, dshwang, drott+blinkwatch_chromium.org, krit, f(malita), jbroman, Justin Novosad, kinuko+watch, pdr+graphicswatchlist_chromium.org, rwlbuis, Stephen Chennney
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove infinite clip in PaintArtifactCompositor. BUG=668342 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Committed: https://crrev.com/b1e93efba353876e43c8b2007cdba51c033785cd Cr-Commit-Position: refs/heads/master@{#440985}

Patch Set 1 #

Patch Set 2 : none #

Total comments: 2

Patch Set 3 : none #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -12 lines) Patch
M third_party/WebKit/Source/platform/graphics/compositing/PaintArtifactCompositor.cpp View 1 1 chunk +2 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/paint/GeometryMapper.h View 1 2 chunks +7 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/paint/GeometryMapperTest.cpp View 1 2 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 22 (16 generated)
chrishtr
3 years, 11 months ago (2016-12-29 19:13:18 UTC) #12
wkorman
lgtm https://codereview.chromium.org/2604083002/diff/20001/third_party/WebKit/Source/platform/graphics/paint/GeometryMapper.h File third_party/WebKit/Source/platform/graphics/paint/GeometryMapper.h (right): https://codereview.chromium.org/2604083002/diff/20001/third_party/WebKit/Source/platform/graphics/paint/GeometryMapper.h#newcode130 third_party/WebKit/Source/platform/graphics/paint/GeometryMapper.h:130: FloatRect localToAncestorClipRect( nit: this is only unit tested ...
3 years, 11 months ago (2016-12-29 19:20:40 UTC) #13
chrishtr
https://codereview.chromium.org/2604083002/diff/20001/third_party/WebKit/Source/platform/graphics/paint/GeometryMapper.h File third_party/WebKit/Source/platform/graphics/paint/GeometryMapper.h (right): https://codereview.chromium.org/2604083002/diff/20001/third_party/WebKit/Source/platform/graphics/paint/GeometryMapper.h#newcode130 third_party/WebKit/Source/platform/graphics/paint/GeometryMapper.h:130: FloatRect localToAncestorClipRect( On 2016/12/29 at 19:20:40, wkorman wrote: > ...
3 years, 11 months ago (2016-12-29 19:34:21 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2604083002/40001
3 years, 11 months ago (2016-12-29 19:34:38 UTC) #17
commit-bot: I haz the power
Committed patchset #3 (id:40001)
3 years, 11 months ago (2016-12-29 21:08:04 UTC) #20
commit-bot: I haz the power
3 years, 11 months ago (2017-01-02 15:53:08 UTC) #22
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/b1e93efba353876e43c8b2007cdba51c033785cd
Cr-Commit-Position: refs/heads/master@{#440985}

Powered by Google App Engine
This is Rietveld 408576698