Log intents received differently if they are internal or external.

tools/metrics/actions/actions.xml

Index: tools/metrics/actions/actions.xml
diff --git a/tools/metrics/actions/actions.xml b/tools/metrics/actions/actions.xml
index 72d028fd39ef74c96def1f841ca87625b5c32b78..1cc7dc8bb23e02ab62f4f626072934b1b6cc079f 100644
--- a/tools/metrics/actions/actions.xml
+++ b/tools/metrics/actions/actions.xml
@@ -9916,8 +9916,27 @@ should be able to be added at any place in this file.
 </action>
 
 <action name="MobileReceivedExternalIntent">
-  <owner>Please list the metric's owners. Add more owner tags as needed.</owner>
-  <description>Please enter the description of this user action.</description>
+  <owner>mariakhomenko@chromium.org, tedchoc@chromium.org</owner>

[Mark P, 2017/01/05 22:41:19]

owner is a repeated field, one user per entry
ditto below

+  <description>
+    A VIEW intent was received by the tabbed mode activity.  This will combine
+    intents sent by external application as well as Chrome itself.
+  </description>
+</action>
+
+<action name="MobileReceivedExternalIntent.App">
+  <owner>mariakhomenko@chromium.org, tedchoc@chromium.org</owner>
+  <description>
+    A VIEW intent was received by the tabbed mode activity from an external
+    application.
+  </description>
+</action>
+
+<action name="MobileReceivedExternalIntent.Chrome">
+  <owner>mariakhomenko@chromium.org, tedchoc@chromium.org</owner>
+  <description>
+    A VIEW intent was received by the tabbed mode activity from Chrome.  This is
+    only recorded for intent types that are also allowed from external apps.
+  </description>
 </action>
 
 <action name="MobileRendererCrashed">
@@ -10013,6 +10032,21 @@ should be able to be added at any place in this file.
   <description>Please enter the description of this user action.</description>
 </action>
 
+<action name="MobileTabbedModeViewIntentFromApp">

[Mark P, 2017/01/05 22:41:19]

Naively, if I read the description of these two actions here:
A VIEW intent was received by the tabbed mode activity from an external
application.
and
A VIEW intent was received by the tabbed mode activity from Chrome.
I'd think I can add them up to yield:
A VIEW intent was received by the tabbed mode activity.  This will combine
intents sent by external application as well as Chrome itself.

This last bit is your description of MobileReceivedExternalIntent.

Yet I know this isn't the case.  The latter is only logged in some subset of
those cases (switch (tabOpenType) ...).

Can you revise the descriptions so that people like me don't make the inference
I made above?

[Ted C, 2017/01/05 23:59:46]

Done.  I initially marked MobileReceivedExternalIntent as obsolete to try
and achieve this, but Maria pointed out this has implications in the UI that
I don't want to trigger quite yet.

+  <owner>mariakhomenko@chromium.org, tedchoc@chromium.org</owner>
+  <description>
+    A VIEW intent was received by the tabbed mode activity from an external
+    application.
+  </description>
+</action>
+
+<action name="MobileTabbedModeViewIntentFromChrome">
+  <owner>mariakhomenko@chromium.org, tedchoc@chromium.org</owner>
+  <description>
+    A VIEW intent was received by the tabbed mode activity from Chrome.
+  </description>
+</action>
+
 <action name="MobileToolbarBack">
   <owner>Please list the metric's owners. Add more owner tags as needed.</owner>
   <description>Please enter the description of this user action.</description>