Log intents received differently if they are internal or external.

tools/metrics/actions/actions.xml

 <!--
 Copyright 2014 The Chromium Authors. All rights reserved.
 Use of this source code is governed by a BSD-style license that can be
 found in the LICENSE file.
 -->
 
 <!--
 This file is a comprehensive list of Chrome user actions along with the owner
 and description for each user action.
 
@@ skipping 9898 matching lines @@
     User marked one or multiple ReadingList entries as 'Unread'.
   </description>
 </action>
 
 <action name="MobileReadingListOpen">
   <owner>gambard@chromium.org</owner>
   <description>User opened a ReadingList entry.</description>
 </action>
 
 <action name="MobileReceivedExternalIntent">
-  <owner>Please list the metric's owners. Add more owner tags as needed.</owner>
-  <description>Please enter the description of this user action.</description>
+  <owner>mariakhomenko@chromium.org, tedchoc@chromium.org</owner>

[Mark P, 2017/01/05 22:41:19]

owner is a repeated field, one user per entry
ditto below

+  <description>
+    A VIEW intent was received by the tabbed mode activity.  This will combine
+    intents sent by external application as well as Chrome itself.
+  </description>
+</action>
+
+<action name="MobileReceivedExternalIntent.App">
+  <owner>mariakhomenko@chromium.org, tedchoc@chromium.org</owner>
+  <description>
+    A VIEW intent was received by the tabbed mode activity from an external
+    application.
+  </description>
+</action>
+
+<action name="MobileReceivedExternalIntent.Chrome">
+  <owner>mariakhomenko@chromium.org, tedchoc@chromium.org</owner>
+  <description>
+    A VIEW intent was received by the tabbed mode activity from Chrome.  This is
+    only recorded for intent types that are also allowed from external apps.
+  </description>
 </action>
 
 <action name="MobileRendererCrashed">
   <owner>Please list the metric's owners. Add more owner tags as needed.</owner>
   <description>Please enter the description of this user action.</description>
 </action>
 
 <action name="MobileSadTabFeedback">
   <owner>jwanda@chromium.org</owner>
   <description>
@@ skipping 75 matching lines @@
   <owner>Please list the metric's owners. Add more owner tags as needed.</owner>
   <description>Please enter the description of this user action.</description>
   <obsolete>Deprecated as of 5/2015</obsolete>
 </action>
 
 <action name="MobileTabSwitched">
   <owner>Please list the metric's owners. Add more owner tags as needed.</owner>
   <description>Please enter the description of this user action.</description>
 </action>
 
+<action name="MobileTabbedModeViewIntentFromApp">

[Mark P, 2017/01/05 22:41:19]

Naively, if I read the description of these two actions here:
A VIEW intent was received by the tabbed mode activity from an external
application.
and
A VIEW intent was received by the tabbed mode activity from Chrome.
I'd think I can add them up to yield:
A VIEW intent was received by the tabbed mode activity.  This will combine
intents sent by external application as well as Chrome itself.

This last bit is your description of MobileReceivedExternalIntent.

Yet I know this isn't the case.  The latter is only logged in some subset of
those cases (switch (tabOpenType) ...).

Can you revise the descriptions so that people like me don't make the inference
I made above?

[Ted C, 2017/01/05 23:59:46]

Done.  I initially marked MobileReceivedExternalIntent as obsolete to try
and achieve this, but Maria pointed out this has implications in the UI that
I don't want to trigger quite yet.

+  <owner>mariakhomenko@chromium.org, tedchoc@chromium.org</owner>
+  <description>
+    A VIEW intent was received by the tabbed mode activity from an external
+    application.
+  </description>
+</action>
+
+<action name="MobileTabbedModeViewIntentFromChrome">
+  <owner>mariakhomenko@chromium.org, tedchoc@chromium.org</owner>
+  <description>
+    A VIEW intent was received by the tabbed mode activity from Chrome.
+  </description>
+</action>
+
 <action name="MobileToolbarBack">
   <owner>Please list the metric's owners. Add more owner tags as needed.</owner>
   <description>Please enter the description of this user action.</description>
 </action>
 
 <action name="MobileToolbarDownloadPage">
   <owner>dfalcantara@chromium.org</owner>
   <owner>twellington@chromium.org</owner>
   <owner>ianwen@chromium.org</owner>
   <description>User pressed the download page icon in the toolbar.</description>
@@ skipping 6093 matching lines @@
 <action name="webapps.AddShortcut.Manifest">
   <owner>mlamouri@chromium.org</owner>
   <description>
     Shortcut added to the homescreen with a valid Manifest. This action will be
     recorded in addition to AppShortcut, AppShortcutApple and Bookmark actions
     to keep a trend of whether the webapp also add meta tags.
   </description>
 </action>
 
 </actions>