[Extensions] Use base::StringPiece in ErrorUtils

[Extensions] Use base::StringPiece in ErrorUtils

ErrorUtils are used to construct errors or warnings, and are usually
based on const char[]s. Change method signature to take a string piece
to avoid constructing a bunch of temporary std::strings.

BUG=None

Committed: https://crrev.com/24e8964b3cd00020aba01217cfee6b88c1804bbf
Cr-Commit-Position: refs/heads/master@{#440907}

[Devlin, 2016-12-28 21:06:22]

The CQ bit was checked by rdevlin.cronin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-28 21:06:33]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-28 21:51:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-28 21:51:50]

Dry run: This issue passed the CQ dry run.

[Devlin, 2016-12-28 23:36:01]

rdevlin.cronin@chromium.org changed reviewers:
+ lazyboy@chromium.org

[lazyboy, 2016-12-28 23:39:04]

lgtm

[Devlin, 2016-12-28 23:43:36]

The CQ bit was checked by rdevlin.cronin@chromium.org

[commit-bot: I haz the power, 2016-12-28 23:43:50]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-28 23:48:43]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1482968616105680, "parent_rev":
"af1e86202b04a491483ce787ac496ad2c63e7bb2", "commit_rev":
"72040f543b53b4e9151efc169d414219d7404dc1"}

[commit-bot: I haz the power, 2016-12-28 23:49:08]

Description was changed from

==========
[Extensions] Use base::StringPiece in ErrorUtils

ErrorUtils are used to construct errors or warnings, and are usually
based on const char[]s. Change method signature to take a string piece
to avoid constructing a bunch of temporary std::strings.

BUG=None
==========

to

==========
[Extensions] Use base::StringPiece in ErrorUtils

ErrorUtils are used to construct errors or warnings, and are usually
based on const char[]s. Change method signature to take a string piece
to avoid constructing a bunch of temporary std::strings.

BUG=None

Review-Url: https://codereview.chromium.org/2604033002
==========

[commit-bot: I haz the power, 2016-12-28 23:49:09]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2017-01-02 15:50:48]

Description was changed from

==========
[Extensions] Use base::StringPiece in ErrorUtils

ErrorUtils are used to construct errors or warnings, and are usually
based on const char[]s. Change method signature to take a string piece
to avoid constructing a bunch of temporary std::strings.

BUG=None

Review-Url: https://codereview.chromium.org/2604033002
==========

to

==========
[Extensions] Use base::StringPiece in ErrorUtils

ErrorUtils are used to construct errors or warnings, and are usually
based on const char[]s. Change method signature to take a string piece
to avoid constructing a bunch of temporary std::strings.

BUG=None

Committed: https://crrev.com/24e8964b3cd00020aba01217cfee6b88c1804bbf
Cr-Commit-Position: refs/heads/master@{#440907}
==========

[commit-bot: I haz the power, 2017-01-02 15:50:49]

Patchset 1 (id:??) landed as
https://crrev.com/24e8964b3cd00020aba01217cfee6b88c1804bbf
Cr-Commit-Position: refs/heads/master@{#440907}