Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(178)

Issue 2603973002: Import Objective C Frameworks (Closed)

Created:
3 years, 11 months ago by Olivier
Modified:
3 years, 11 months ago
CC:
asvitkine+watch_chromium.org, cbentzel+watch_chromium.org, chromium-reviews, chromoting-reviews_chromium.org, darin-cc_chromium.org, feature-media-reviews_chromium.org, grt+watch_chromium.org, jam, jochen+watch_chromium.org, mac-reviews_chromium.org, mlamouri+watch-content_chromium.org, noyau+watch_chromium.org, Peter Beverloo, pkl (ping after 24h if needed), rsesek+watch_chromium.org, sdefresne+watch_chromium.org, tfarina
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Import Objective C Frameworks The Objective-C frameworks must be imported and not included. List of Objective-C Frameworks that have been checked: AVFoundation AVKit Accounts AdSupport AddressBookUI AssetsLibrary CallKit CloudKit Contacts ContactsUI CoreAudioKit CoreBluetooth CoreData CoreImage CoreLocation CoreMIDI CoreMotion CoreSpotlight EventKit EventKitUI ExternalAccessory Foundation GLKit GameController GameKit GameplayKit HealthKit HealthKitUI HomeKit Intents IntentsUI JavaScriptCore LocalAuthentication MapKit MediaPlayer MessageUI Messages Metal MetalKit MetalPerformanceShaders ModelIO MultipeerConnectivity NetworkExtension NewsstandKit NotificationCenter PassKit Photos PhotosUI PushKit QuickLook ReplayKit SafariServices SceneKit Social Speech SpriteKit StoreKit Twitter UIKit UserNotifications UserNotificationsUI VideoSubscriberAccount WatchConnectivity WatchKit WebKit iAd BUG= Committed: https://crrev.com/95d21f263357ceb246b1bc1f2b59acb0d26c818e Cr-Commit-Position: refs/heads/master@{#440848}

Patch Set 1 #

Patch Set 2 : only ios #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -50 lines) Patch
M ios/chrome/app/application_delegate/fake_startup_information.h View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/app/chrome_app_startup_parameters_unittest.mm View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/app/safe_mode/safe_mode_coordinator_unittest.mm View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/chrome_coordinator.h View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/crash_loop_detection_util_unittest.mm View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/crash_report/crash_report_helper.mm View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/crash_report/crash_report_multi_parameter.h View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/install_time_util.mm View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/metrics/mobile_session_shutdown_metrics_provider.mm View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/omaha/omaha_service.mm View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/procedural_block_types.h View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/root_coordinator.h View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/signin/authentication_service.mm View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/signin/chrome_identity_service_observer_bridge.h View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/signin/constants.h View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/signin/signin_util.h View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/suggestions/image_fetcher_impl.mm View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/suggestions/ios_image_decoder_impl.mm View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/ui/background_generator.h View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/ui/bookmarks/bookmark_model_bridge_observer.mm View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/ui/collection_view/collection_view_model.h View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/ui/contextual_search/touch_to_search_permissions_mediator_unittest.mm View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/ui/first_run/static_file_view_controller.mm View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/ui/main/browser_view_wrangler_unittest.mm View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/ui/main/main_coordinator_unittest.mm View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/ui/main/main_view_controller_unittest.mm View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/ui/material_components/activity_indicator.h View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/ui/omnibox/location_bar_view_ios.h View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/ui/omnibox/location_bar_view_ios.mm View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/ui/omnibox/omnibox_popup_view_ios.h View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/ui/omnibox/omnibox_view_ios.h View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/ui/show_mail_composer_util.mm View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/ui/static_content/static_html_view_controller.mm View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/ui/sync/sync_util.h View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/web/auto_reload_bridge.h View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/web/auto_reload_controller.h View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/web/chrome_web_client_unittest.mm View 1 chunk +1 line, -1 line 0 comments Download
M ios/net/cookies/cookie_creation_time_manager.mm View 1 chunk +1 line, -1 line 0 comments Download
M ios/net/http_protocol_logging.mm View 1 chunk +1 line, -1 line 0 comments Download
M ios/net/http_response_headers_util.mm View 1 chunk +1 line, -1 line 0 comments Download
M ios/net/nsurlrequest_util.h View 1 chunk +1 line, -1 line 0 comments Download
M ios/public/provider/chrome/browser/signin/test_signin_resources_provider.mm View 1 chunk +1 line, -1 line 0 comments Download
M ios/public/provider/chrome/browser/voice/logo_animation_controller.h View 1 chunk +1 line, -1 line 0 comments Download
M ios/public/provider/chrome/browser/voice/voice_search_provider.h View 1 chunk +2 lines, -2 lines 0 comments Download
M ios/web/net/request_group_util.mm View 1 chunk +1 line, -1 line 0 comments Download
M ios/web/net/request_group_util_unittest.mm View 1 chunk +1 line, -1 line 0 comments Download
M ios/web/public/web_client.mm View 1 chunk +1 line, -1 line 0 comments Download
M ios/web/public/web_state/crw_web_user_interface_delegate.h View 1 chunk +1 line, -1 line 0 comments Download
M ios/web/web_state/js/common_js_unittest.mm View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 16 (8 generated)
Olivier
3 years, 11 months ago (2016-12-28 13:34:39 UTC) #2
marq (ping after 24h)
lgtm
3 years, 11 months ago (2016-12-28 13:52:09 UTC) #5
marq (ping after 24h)
On 2016/12/28 13:52:09, marq wrote: > lgtm You will need to add other OWNERS; you ...
3 years, 11 months ago (2016-12-28 13:53:50 UTC) #6
Olivier
On 2016/12/28 at 13:53:50, marq wrote: > On 2016/12/28 13:52:09, marq wrote: > > lgtm ...
3 years, 11 months ago (2016-12-28 13:58:41 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2603973002/20001
3 years, 11 months ago (2016-12-28 14:03:02 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
3 years, 11 months ago (2016-12-28 14:22:19 UTC) #13
Eugene But (OOO till 7-30)
lgtm! Thank you for doing this
3 years, 11 months ago (2016-12-28 17:05:15 UTC) #14
commit-bot: I haz the power
3 years, 11 months ago (2017-01-02 15:48:59 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/95d21f263357ceb246b1bc1f2b59acb0d26c818e
Cr-Commit-Position: refs/heads/master@{#440848}

Powered by Google App Engine
This is Rietveld 408576698