Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Unified Diff: third_party/WebKit/Source/bindings/core/v8/WindowProxy.cpp

Issue 2603953002: Remove an isGlobalInitialized() check from WindowProxy::updateDocument() (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/bindings/core/v8/WindowProxy.cpp
diff --git a/third_party/WebKit/Source/bindings/core/v8/WindowProxy.cpp b/third_party/WebKit/Source/bindings/core/v8/WindowProxy.cpp
index 1a2c2bccc9faae9d6719b449bd03ebb5173cbb3d..3f56f38cc356ee965380843f9bc06cd6020e9e6b 100644
--- a/third_party/WebKit/Source/bindings/core/v8/WindowProxy.cpp
+++ b/third_party/WebKit/Source/bindings/core/v8/WindowProxy.cpp
@@ -468,10 +468,9 @@ void WindowProxy::setSecurityToken(SecurityOrigin* origin) {
void WindowProxy::updateDocument() {
DCHECK(m_world->isMainWorld());
- if (!isGlobalInitialized())
- return;
if (!isContextInitialized())
haraken 2016/12/28 08:45:43 Actually I think this check is wrong. updateDocume
Yuki 2016/12/28 08:53:19 Why updateDocument should run when the context is
return;
+
updateActivityLogger();
updateDocumentProperty();
updateSecurityOrigin(m_frame->securityContext()->getSecurityOrigin());
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698