Give up looking up interned names if the encoding changed during parsing

Give up looking up interned names if the encoding changed during parsing

NEXTL may process encoding changes by refilling the parser's input
buffer, which makes the accumulated length 'len' inaccurate.

BUG=620679
Review-Url: https://codereview.chromium.org/2603933002
Cr-Commit-Position: refs/heads/master@{#442517}
Committed: https://chromium.googlesource.com/chromium/src/+/6b6cc2b4809e9e7479b03e69b39f613f2de70e0b

[dominicc (has gone to gerrit), 2016-12-28 05:46:13]

The CQ bit was checked by dominicc@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-28 05:46:16]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dominicc (has gone to gerrit), 2016-12-28 05:53:50]

dominicc@chromium.org changed reviewers:
+ mmoroz@chromium.org

[dominicc (has gone to gerrit), 2016-12-28 05:53:51]

PTAL

This is a bit of a bandaid, very like what we have for htmlParseNameComplex here
[1]. To summarize what's happening:

NEXTL may detect a different encoding and switch it, crucially refilling
ctxt->input->base with content that is a different length. After that, the
accumulated 'len' is inaccurate.

A thorough fix is tedious because you'd have to build an xmlParseNameComplex
which would no longer switch encodings until it was past a certain point in the
input, but defining that point is tricky because the input you're reparsing is a
different size.

[1]
https://cs.chromium.org/chromium/src/third_party/libxml/src/HTMLparser.c?cl=G...

[commit-bot: I haz the power, 2016-12-28 06:43:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-28 06:43:01]

Dry run: This issue passed the CQ dry run.

[mmoroz, 2016-12-28 09:23:39]

LGTM, thanks Dominic for the detailed explanation!

[dominicc (has gone to gerrit), 2017-01-10 04:38:41]

The CQ bit was checked by dominicc@chromium.org

[commit-bot: I haz the power, 2017-01-10 04:39:42]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-10 06:19:15]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1484023121930840, "parent_rev":
"41ba1486431391060dd80bce6b6f60ffe0a8df8e", "commit_rev":
"6b6cc2b4809e9e7479b03e69b39f613f2de70e0b"}

[commit-bot: I haz the power, 2017-01-10 06:19:58]

Description was changed from

==========
Give up looking up interned names if the encoding changed during parsing

NEXTL may process encoding changes by refilling the parser's input
buffer, which makes the accumulated length 'len' inaccurate.

BUG=620679
==========

to

==========
Give up looking up interned names if the encoding changed during parsing

NEXTL may process encoding changes by refilling the parser's input
buffer, which makes the accumulated length 'len' inaccurate.

BUG=620679

Review-Url: https://codereview.chromium.org/2603933002
Cr-Commit-Position: refs/heads/master@{#442517}
Committed:
https://chromium.googlesource.com/chromium/src/+/6b6cc2b4809e9e7479b03e69b39f...
==========

[commit-bot: I haz the power, 2017-01-10 06:19:58]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/6b6cc2b4809e9e7479b03e69b39f...