Issue 2603923002: Merge 2924: Add RELEASE_ASSERT to InlineTextBox::constructTextRun

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2603923002: Merge 2924: Add RELEASE_ASSERT to InlineTextBox::constructTextRun (Closed)

Created:
3 years, 12 months ago by kojii

Modified:
3 years, 12 months ago

Reviewers:

CC:
chromium-reviews

Target Ref:
refs/pending/branch-heads/2924

Project:
chromium

Visibility:
Public.

Merge 2924: Add RELEASE_ASSERT to InlineTextBox::constructTextRun This patch adds RELEASE_CHECK of offset and length to InlineTextBox::constructTextRun(). StringView constructor only does SECURITY_DCHECK intentionally, see http://crrev.com/2587863002. BUG=671328 Review-Url: https://codereview.chromium.org/2588193003 Cr-Commit-Position: refs/heads/master@{#439721} (cherry picked from commit 74c7fa91b738155df1b8bb871d81f92c28c7941a) Committed: https://chromium.googlesource.com/chromium/src/+/2ac9e9c9ba1bf98338b30c592c9c355eba71e73b

Created: 3 years, 12 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -0 lines)			Patch
	M	third_party/WebKit/Source/core/layout/line/InlineTextBox.cpp	View		1 chunk	+4 lines, -0 lines	0 comments	Download

Total messages: 2 (1 generated)

kojii

3 years, 12 months ago (2016-12-28 05:01:19 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
2ac9e9c9ba1bf98338b30c592c9c355eba71e73b.