Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2588193003:
Add RELEASE_ASSERT to InlineTextBox::constructTextRun (Closed)
|
Created:
4 years ago by kojii Modified:
4 years ago Reviewers:
esprehn CC:
blink-reviews, blink-reviews-layout_chromium.org, chromium-reviews, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1 Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionAdd RELEASE_ASSERT to InlineTextBox::constructTextRun
This patch adds RELEASE_CHECK of offset and length to
InlineTextBox::constructTextRun(). StringView constructor only does
SECURITY_DCHECK intentionally, see http://crrev.com/2587863002.
BUG=671328
Committed: https://crrev.com/74c7fa91b738155df1b8bb871d81f92c28c7941a
Cr-Commit-Position: refs/heads/master@{#439721}
Patch Set 1 #Patch Set 2 : Add comment #Messages
Total messages: 21 (15 generated)
The CQ bit was checked by kojii@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== constructTextRun-RELEASE_ASSERT BUG= ========== to ========== Add RELEASE_ASSERT to InlineTextBox::constructTextRun This patch adds RELEASE_CHECK of offset and length to InlineTextBox::constructTextRun(). StringView constructor only does SECURITY_DCHECK intentionally, see http://crrev.com/2588193003. BUG=671328 ==========
kojii@chromium.org changed reviewers: + esprehn@chromium.org
PTAL. This isn't required with crrev.com/2586853002, but is this still nice to take, or is this something we should try to avoid in the release builds? I'll add the detail to the CL, sorry, I should have asked you to review both CLs, thought you're too high level for a tiny layout bug.
lgtm. I suspect in this case the one extra branch is not a big deal in terms of perf. You might want to add a comment to the code about it?
Description was changed from ========== Add RELEASE_ASSERT to InlineTextBox::constructTextRun This patch adds RELEASE_CHECK of offset and length to InlineTextBox::constructTextRun(). StringView constructor only does SECURITY_DCHECK intentionally, see http://crrev.com/2588193003. BUG=671328 ========== to ========== Add RELEASE_ASSERT to InlineTextBox::constructTextRun This patch adds RELEASE_CHECK of offset and length to InlineTextBox::constructTextRun(). StringView constructor only does SECURITY_DCHECK intentionally, see http://crrev.com/2586853002. BUG=671328 ==========
Description was changed from ========== Add RELEASE_ASSERT to InlineTextBox::constructTextRun This patch adds RELEASE_CHECK of offset and length to InlineTextBox::constructTextRun(). StringView constructor only does SECURITY_DCHECK intentionally, see http://crrev.com/2586853002. BUG=671328 ========== to ========== Add RELEASE_ASSERT to InlineTextBox::constructTextRun This patch adds RELEASE_CHECK of offset and length to InlineTextBox::constructTextRun(). StringView constructor only does SECURITY_DCHECK intentionally, see http://crrev.com/2587863002. BUG=671328 ==========
The CQ bit was checked by kojii@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
On 2016/12/20 at 03:44:57, esprehn wrote: > You might want to add a comment to the code about it? Done, thank you for your prompt review.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by kojii@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from esprehn@chromium.org Link to the patchset: https://codereview.chromium.org/2588193003/#ps20001 (title: "Add comment")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1482213209575360,
"parent_rev": "4c6322716a29c60579ff97c80b71fa3a0c2b8201", "commit_rev":
"0db5bde56bb8da6aa985e18a00c4baabc31fa3b1"}
Message was sent while issue was closed.
Description was changed from ========== Add RELEASE_ASSERT to InlineTextBox::constructTextRun This patch adds RELEASE_CHECK of offset and length to InlineTextBox::constructTextRun(). StringView constructor only does SECURITY_DCHECK intentionally, see http://crrev.com/2587863002. BUG=671328 ========== to ========== Add RELEASE_ASSERT to InlineTextBox::constructTextRun This patch adds RELEASE_CHECK of offset and length to InlineTextBox::constructTextRun(). StringView constructor only does SECURITY_DCHECK intentionally, see http://crrev.com/2587863002. BUG=671328 Review-Url: https://codereview.chromium.org/2588193003 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Add RELEASE_ASSERT to InlineTextBox::constructTextRun This patch adds RELEASE_CHECK of offset and length to InlineTextBox::constructTextRun(). StringView constructor only does SECURITY_DCHECK intentionally, see http://crrev.com/2587863002. BUG=671328 Review-Url: https://codereview.chromium.org/2588193003 ========== to ========== Add RELEASE_ASSERT to InlineTextBox::constructTextRun This patch adds RELEASE_CHECK of offset and length to InlineTextBox::constructTextRun(). StringView constructor only does SECURITY_DCHECK intentionally, see http://crrev.com/2587863002. BUG=671328 Committed: https://crrev.com/74c7fa91b738155df1b8bb871d81f92c28c7941a Cr-Commit-Position: refs/heads/master@{#439721} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/74c7fa91b738155df1b8bb871d81f92c28c7941a Cr-Commit-Position: refs/heads/master@{#439721} |
