DevTools: [Persistence] start searching in JSON/MarkDown files

DevTools: [Persistence] start searching in JSON/MarkDown files

Every UISourceCode coming from filesystem is attributed with a resource
type. "search all files" relies on this resourceType to skip non-text
resources.

In order to search in as many text files as possible, we should blacklist
binary files instead of whitelisting text files.

This patch introduces a set of common binary extensions. A file with binary
extension is attributed with ResourceType.Other type, and a file with
text extension is attributed with ReosurceType.Document.

BUG=none
R=dgozman

Review-Url: https://codereview.chromium.org/2603913002
Cr-Commit-Position: refs/heads/master@{#445333}
Committed: https://chromium.googlesource.com/chromium/src/+/0a70ea39525afdde25c161e54c100aadca530e0c

[lushnikov, 2016-12-28 04:25:28]

please, take a look!

[lushnikov, 2016-12-28 04:25:40]

The CQ bit was checked by lushnikov@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-28 04:25:52]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-28 05:57:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-28 05:57:07]

Dry run: This issue passed the CQ dry run.

[dgozman, 2016-12-28 18:42:26]

I'm not sure about this patch. What about .a, .exe, .bin, .dll, .pyc or
something else? I'd expect those to be in my checkout.

Let's maybe whitelist more things?

[lushnikov, 2016-12-28 21:15:07]

On 2016/12/28 18:42:26, dgozman wrote:
> I'm not sure about this patch. What about .a, .exe, .bin, .dll, .pyc or
> something else? I'd expect those to be in my checkout.
> 
> Let's maybe whitelist more things?

It looks like it's better to show more irrelevant information rather then
pretend that there's no search result (the first error is easily discoverable,
the second is not so much).
There's .a already, and i can easily add others

[lushnikov, 2017-01-06 21:00:19]

should we land this for now? Are there any major concerns with this approach?

[dgozman, 2017-01-06 21:49:07]

lgtm, but please add more binary ones (at least, executables, which are huge and
will kill our search performance).

[lushnikov, 2017-01-23 06:29:43]

thanks, added executables

[lushnikov, 2017-01-23 06:29:47]

The CQ bit was checked by lushnikov@chromium.org

[lushnikov, 2017-01-23 06:29:47]

The patchset sent to the CQ was uploaded after l-g-t-m from dgozman@chromium.org
Link to the patchset: https://codereview.chromium.org/2603913002/#ps20001
(title: "add executable extensions")

[commit-bot: I haz the power, 2017-01-23 06:30:01]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-23 08:14:15]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1485152987032560,
"parent_rev": "abe8d4deee2526462924b56e98346484a21feda2", "commit_rev":
"0a70ea39525afdde25c161e54c100aadca530e0c"}

[commit-bot: I haz the power, 2017-01-23 08:14:48]

Description was changed from

==========
DevTools: [Persistence] start searching in JSON/MarkDown files

Every UISourceCode coming from filesystem is attributed with a resource
type. "search all files" relies on this resourceType to skip non-text
resources.

In order to search in as many text files as possible, we should blacklist
binary files instead of whitelisting text files.

This patch introduces a set of common binary extensions. A file with binary
extension is attributed with ResourceType.Other type, and a file with
text extension is attributed with ReosurceType.Document.

BUG=none
R=dgozman
==========

to

==========
DevTools: [Persistence] start searching in JSON/MarkDown files

Every UISourceCode coming from filesystem is attributed with a resource
type. "search all files" relies on this resourceType to skip non-text
resources.

In order to search in as many text files as possible, we should blacklist
binary files instead of whitelisting text files.

This patch introduces a set of common binary extensions. A file with binary
extension is attributed with ResourceType.Other type, and a file with
text extension is attributed with ReosurceType.Document.

BUG=none
R=dgozman

Review-Url: https://codereview.chromium.org/2603913002
Cr-Commit-Position: refs/heads/master@{#445333}
Committed:
https://chromium.googlesource.com/chromium/src/+/0a70ea39525afdde25c161e54c10...
==========

[commit-bot: I haz the power, 2017-01-23 08:14:49]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/0a70ea39525afdde25c161e54c10...