Issue 2603903002: Don't show geolocation disclosure when in incognito mode.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2603903002: Don't show geolocation disclosure when in incognito mode. (Closed)

Created:
3 years, 12 months ago by benwells

Modified:
3 years, 12 months ago

Reviewers:

CC:
chromium-reviews

Target Ref:
refs/pending/branch-heads/2924

Project:
chromium

Visibility:
Public.

Don't show geolocation disclosure when in incognito mode. The geolocation will not be shared, so the disclosure should not be shown. BUG=676240 Review-Url: https://codereview.chromium.org/2593943002 Cr-Commit-Position: refs/heads/master@{#440244} (cherry picked from commit 62c93a50d8856db7621bc98d4c59794c58474ee2) Committed: https://chromium.googlesource.com/chromium/src/+/4b8e02b901e22228729049f87d05320f27cb65fc

Created: 3 years, 12 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -0 lines)			Patch
	M	chrome/browser/android/search_geolocation_disclosure_tab_helper.cc	View		1 chunk	+4 lines, -0 lines	0 comments	Download

Total messages: 2 (1 generated)

benwells

3 years, 12 months ago (2016-12-28 03:40:25 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
4b8e02b901e22228729049f87d05320f27cb65fc.