Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(293)

Issue 2593943002: Don't show geolocation disclosure when in incognito mode. (Closed)

Created:
4 years ago by benwells
Modified:
4 years ago
Reviewers:
gone
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Don't show geolocation disclosure when in incognito mode. The geolocation will not be shared, so the disclosure should not be shown. BUG=676240 Committed: https://crrev.com/62c93a50d8856db7621bc98d4c59794c58474ee2 Cr-Commit-Position: refs/heads/master@{#440244}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M chrome/browser/android/search_geolocation_disclosure_tab_helper.cc View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (9 generated)
benwells
Hey Dan, it's a bit nasty that the disclosure is being shown in incognito, so ...
4 years ago (2016-12-21 06:19:00 UTC) #4
benwells
Hey Dan, it's a bit nasty that the disclosure is being shown in incognito, so ...
4 years ago (2016-12-21 06:19:02 UTC) #5
gone
lgtm
4 years ago (2016-12-21 18:34:04 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2593943002/1
4 years ago (2016-12-21 22:28:05 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-21 22:35:29 UTC) #13
commit-bot: I haz the power
4 years ago (2016-12-21 22:40:17 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/62c93a50d8856db7621bc98d4c59794c58474ee2
Cr-Commit-Position: refs/heads/master@{#440244}

Powered by Google App Engine
This is Rietveld 408576698