Add QuicLRUCache.

Add QuicLRUCache.

Merge internal change 143035999.

BUG=

Committed: https://crrev.com/8ea75ec04ded52c66874700d30666933787a7eb9
Cr-Commit-Position: refs/heads/master@{#440866}

[Fan Yang, 2016-12-27 20:59:42]

The CQ bit was checked by fayang@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-27 20:59:48]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Fan Yang, 2016-12-27 21:07:19]

Description was changed from

==========
Add QuicLRUCache.

Merge internal change 143035999.

BUG=
==========

to

==========
Add QuicLRUCache.

Merge internal change 143035999.

BUG=
==========

[Fan Yang, 2016-12-27 21:07:20]

fayang@chromium.org changed reviewers:
+ rch@chromium.org

[Ryan Hamilton, 2016-12-27 21:57:40]

Same comments as on internal version, plus one more.

https://codereview.chromium.org/2603843002/diff/20001/net/quic/platform/impl/...
File net/quic/platform/impl/quic_lru_cache_impl.h (right):

https://codereview.chromium.org/2603843002/diff/20001/net/quic/platform/impl/...
net/quic/platform/impl/quic_lru_cache_impl.h:19: mru_cache_.Put(key, *value);
Since value is dereferenced, but not released does value get deleted when the
unique_ptr is deleted?

[commit-bot: I haz the power, 2016-12-27 22:09:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-27 22:09:11]

Dry run: This issue passed the CQ dry run.

[Fan Yang, 2016-12-27 23:36:39]

On 2016/12/27 21:57:40, Ryan Hamilton wrote:
> Same comments as on internal version, plus one more.
> 
>
https://codereview.chromium.org/2603843002/diff/20001/net/quic/platform/impl/...
> File net/quic/platform/impl/quic_lru_cache_impl.h (right):
> 
>
https://codereview.chromium.org/2603843002/diff/20001/net/quic/platform/impl/...
> net/quic/platform/impl/quic_lru_cache_impl.h:19: mru_cache_.Put(key, *value);
> Since value is dereferenced, but not released does value get deleted when the
> unique_ptr is deleted?

I think value of MRUCache is a copy of inserted value, so dereference of
unique_ptr is fine, if I get the code correctly?

[Ryan Hamilton, 2016-12-27 23:44:37]

https://codereview.chromium.org/2603843002/diff/20001/net/quic/platform/impl/...
File net/quic/platform/impl/quic_lru_cache_impl.h (right):

https://codereview.chromium.org/2603843002/diff/20001/net/quic/platform/impl/...
net/quic/platform/impl/quic_lru_cache_impl.h:19: mru_cache_.Put(key, *value);
On 2016/12/27 21:57:40, Ryan Hamilton wrote:
> Since value is dereferenced, but not released does value get deleted when the
> unique_ptr is deleted?

Oh, I see. I misunderstood the type of the underlying mru_cache_. In that case,
can you make the value std::unique_ptr<V> instead?

  base::MRUCache<K, std::unique_ptr<V>> mru_cache_;

That would save a copy. In the case of the compressed certs cache, the V is
pretty huge so copying would be nice to avoid.

[Fan Yang, 2016-12-28 14:04:18]

The CQ bit was checked by fayang@chromium.org to run a CQ dry run

[Fan Yang, 2016-12-28 14:04:24]

On 2016/12/27 23:44:37, Ryan Hamilton wrote:
>
https://codereview.chromium.org/2603843002/diff/20001/net/quic/platform/impl/...
> File net/quic/platform/impl/quic_lru_cache_impl.h (right):
> 
>
https://codereview.chromium.org/2603843002/diff/20001/net/quic/platform/impl/...
> net/quic/platform/impl/quic_lru_cache_impl.h:19: mru_cache_.Put(key, *value);
> On 2016/12/27 21:57:40, Ryan Hamilton wrote:
> > Since value is dereferenced, but not released does value get deleted when
the
> > unique_ptr is deleted?
> 
> Oh, I see. I misunderstood the type of the underlying mru_cache_. In that
case,
> can you make the value std::unique_ptr<V> instead?
> 
>   base::MRUCache<K, std::unique_ptr<V>> mru_cache_;
> 
> That would save a copy. In the case of the compressed certs cache, the V is
> pretty huge so copying would be nice to avoid.

I see. Done. This is great. Thanks a lot!

[commit-bot: I haz the power, 2016-12-28 14:04:32]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Fan Yang, 2016-12-28 14:13:13]

The CQ bit was checked by fayang@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-28 14:13:22]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Ryan Hamilton, 2016-12-28 15:11:43]

lgtm

[commit-bot: I haz the power, 2016-12-28 15:16:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-28 15:16:46]

Dry run: This issue passed the CQ dry run.

[Fan Yang, 2016-12-28 17:59:06]

The CQ bit was checked by fayang@chromium.org

[commit-bot: I haz the power, 2016-12-28 17:59:18]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-28 18:03:14]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1482947946223300,
"parent_rev": "476d854e45e632e15a66590c5cdb74e3301aac96", "commit_rev":
"0181b83281d30df8a27bc2352426c880d9b7ae35"}

[commit-bot: I haz the power, 2016-12-28 18:03:39]

Description was changed from

==========
Add QuicLRUCache.

Merge internal change 143035999.

BUG=
==========

to

==========
Add QuicLRUCache.

Merge internal change 143035999.

BUG=

Review-Url: https://codereview.chromium.org/2603843002
==========

[commit-bot: I haz the power, 2016-12-28 18:03:39]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2017-01-02 15:49:31]

Description was changed from

==========
Add QuicLRUCache.

Merge internal change 143035999.

BUG=

Review-Url: https://codereview.chromium.org/2603843002
==========

to

==========
Add QuicLRUCache.

Merge internal change 143035999.

BUG=

Committed: https://crrev.com/8ea75ec04ded52c66874700d30666933787a7eb9
Cr-Commit-Position: refs/heads/master@{#440866}
==========

[commit-bot: I haz the power, 2017-01-02 15:49:32]

Patchset 4 (id:??) landed as
https://crrev.com/8ea75ec04ded52c66874700d30666933787a7eb9
Cr-Commit-Position: refs/heads/master@{#440866}