Chromium Code Reviews
DescriptionFix incognito notification/cleanup for android multiwindow.
When moving an NTP (very specific to the NTP URL) across
CTA instances, it would put the ref in AsyncTabParams, but
would not use it when creating the tab in the second window.
This was bad because it kept a reference to the incognito
tab forever (preventing the profile from being deleted and
the notification from going away).
This also changes the PendingIntent flag to allow the
notification to take an action as long as it is visible
(then if cleaning up the incognito tabs fails the first
time, the second click might succeed).
BUG=673582, 673489
Review-Url: https://codereview.chromium.org/2574143004
Cr-Commit-Position: refs/heads/master@{#438648}
Committed: https://chromium.googlesource.com/chromium/src/+/9af8d43fec1953c20f6804c0f80dfe6ea0da27f7
Patch Set 1 #Messages
Total messages: 2 (1 generated)
|