Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(264)

Issue 2603793002: Fix incognito notification/cleanup for android multiwindow. (Closed)

Created:
3 years, 12 months ago by Ted C
Modified:
3 years, 12 months ago
Reviewers:
CC:
chromium-reviews, agrieve+watch_chromium.org
Target Ref:
refs/pending/branch-heads/2924
Project:
chromium
Visibility:
Public.

Description

Fix incognito notification/cleanup for android multiwindow. When moving an NTP (very specific to the NTP URL) across CTA instances, it would put the ref in AsyncTabParams, but would not use it when creating the tab in the second window. This was bad because it kept a reference to the incognito tab forever (preventing the profile from being deleted and the notification from going away). This also changes the PendingIntent flag to allow the notification to take an action as long as it is visible (then if cleaning up the incognito tabs fails the first time, the second click might succeed). BUG=673582, 673489 Review-Url: https://codereview.chromium.org/2574143004 Cr-Commit-Position: refs/heads/master@{#438648} Committed: https://chromium.googlesource.com/chromium/src/+/9af8d43fec1953c20f6804c0f80dfe6ea0da27f7

Patch Set 1 #

Messages

Total messages: 2 (1 generated)
Ted C
3 years, 12 months ago (2016-12-27 17:37:54 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
9af8d43fec1953c20f6804c0f80dfe6ea0da27f7.

Powered by Google App Engine
This is Rietveld 408576698